Replies: 1 comment
-
Closing this discussion as it was incorporated into the PR submitted as part of the #172 discussion. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Great work BTW on this. I have been using a dockerized version for the past 4.5 years (customized a bit based on my needs).
My docker container is local timezone aware (by passing it the TZ environment variable) and when I finally went through importing the historical daily/hourly data, I noticed that the datapoints were being stored with a timestamp of "UTC midnight; YYYY-MM-DDT23:59:59Z" rather than local timezone midnight; YYYY-MM-DDT23:59:59-5:00.
Note that the above issue is only present when the historical "day" data is pulled via the --historydays argument and NOT for the day data that is filled in on a daily basis during "normal" runs.
Looking at the code, realized that the time variables used for the history subroutines were not localized and so when the datapoint timestamp was set at 23:59:59, it was being done so for the UTC timezone and not local.
Have created a "patch" for the above issue at https://github.com/jertel/vuegraf/compare/master...cooldil:vuegraf:cooldil-patch-1?diff=split&w= that I can submit as a push if appropriate.
Note that the code changes also fix the precision of the second, minute and hour datapoint points so as to prevent duplication of data within the database in case of multiple vuegraf runs.
Beta Was this translation helpful? Give feedback.
All reactions