Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese translation key wrong in docs #2913

Closed
Lutra-Fs opened this issue Aug 9, 2023 · 2 comments
Closed

Chinese translation key wrong in docs #2913

Lutra-Fs opened this issue Aug 9, 2023 · 2 comments

Comments

@Lutra-Fs
Copy link
Contributor

Lutra-Fs commented Aug 9, 2023

Describe the bug
A clear and concise description of what the bug is.
After traditional Chinese translation introduced to the project, the translation key for Chinese is now zh-CN(Simplified Chinese) or zh-TW(Traditional Chinese) instead of zh. Old 'zh' key doesn't work anymore.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'config.yml'
  2. Set the language key to 'zh'
  3. Start lazygit
  4. Lazygit returns "language not found"

Expected behavior
A clear and concise description of what you expected to happen.
Load Chinese translation

Screenshots
If applicable, add screenshots to help explain your problem.

Version info:
Run lazygit --version and paste the result here
Run git --version and paste the result here

Additional context
Add any other context about the problem here.
There is a PR #2842 relates to that.

Note: please try updating to the latest version or manually building the latest master to see if the issue still occurs.

@lucky51
Copy link

lucky51 commented Aug 17, 2023

I set up language: 'zh-CN' for config.yml on windows11 .lazygit can run but show below.

lazygit

@Lutra-Fs
Copy link
Contributor Author

I set up language: 'zh-CN' for config.yml on windows11 .lazygit can run but show below.

lazygit

You already set the language to Chinese, please see this issue #2741 for the CJK character display issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants