-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated left-pad #8516
Labels
Comments
Send a PR please? :) |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
🚀 Feature Proposal
Replace left-pad with String.prototype.padStart() (from deprecation message):
https://www.npmjs.com/package/left-pad
Example
Please provide an example for how this feature would be used.
Need to be done:
Remove left-pad dependency here: https://github.com/facebook/jest/blob/master/package.json#L57
Remove import of
left-pad
here:https://github.com/facebook/jest/blob/master/packages/pretty-format/perf/test.js#L13
Replace
leftPad(current.time, 6)
withString(current.time).padStart(6)
here:https://github.com/facebook/jest/blob/master/packages/pretty-format/perf/test.js#L83
The text was updated successfully, but these errors were encountered: