Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S2L meters draw randomly over the top of the menus at incorrect points #13

Open
jevans3142 opened this issue Feb 25, 2024 · 2 comments
Open

S2L meters draw randomly over the top of the menus at incorrect points #13

jevans3142 opened this issue Feb 25, 2024 · 2 comments
Assignees
@jevans3142
Labels
bug Something isn't working
Milestone
v1.1 with colourfade

Comments

@jevans3142
Copy link
Owner

No description provided.

@jevans3142 jevans3142 added the bug Something isn't working label Feb 25, 2024
@jevans3142 jevans3142 added this to the v1.1 with colourfade milestone Feb 25, 2024
jevans3142 added a commit that referenced this issue Feb 25, 2024
@jevans3142
Reduce S2L meters appearing on menu randomly
ce7d8ba 
Mutex for scene number was being taken for too long when changing screen; should fix most instances - still one race condition left (see #13 comments)
Also correct some indentation
@jevans3142
Copy link
Owner Author

This has been reduced but still one race condition remaining I think: when going from the main status screen into the main menu still may very rarely see the main menu corrupted by the meters. I think this is because the loop in s2l_meter_refresh_task has already gone past the
if (get_screen() == SCREEN_MAIN_STATUS) before the screen number gets changed to the main menu, so it goes ahead and paints the meters anyway

@jevans3142
Copy link
Owner Author

Could probably be resolved by actually pausing and unpausing the task?

@jevans3142 jevans3142 self-assigned this Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jevans3142 jevans3142

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.1 with colourfade
Development

No branches or pull requests
1 participant
@jevans3142