Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lsp hover capability #187

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Lsp hover capability #187

merged 4 commits into from
Feb 7, 2024

Conversation

ehllie
Copy link
Contributor

@ehllie ehllie commented Feb 7, 2024

So far hover only provides any information for variables. Future work could be adding doc comment rendering, as well as support for hovering trait definitions. The language server might also soon be due a slight refactor as the main.rs file is starting to grow a little large.

Hover preview

image

@ehllie
Copy link
Contributor Author

ehllie commented Feb 7, 2024

#179

jfecher
jfecher reviewed Feb 7, 2024
View reviewed changes
Copy link
Owner

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have a few questions, then we can get this merged

ante-ls/src/main.rs Show resolved Hide resolved
ante-ls/src/main.rs Outdated Show resolved Hide resolved
ante-ls/src/main.rs Outdated Show resolved Hide resolved
ante-ls/src/main.rs Outdated Show resolved Hide resolved
jfecher
jfecher approved these changes Feb 7, 2024
View reviewed changes
Copy link
Owner

@jfecher jfecher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes, thank you!

It always makes my day each time there's a new PR - and such an exciting one too.

@jfecher jfecher merged commit 7f6b458 into jfecher:master Feb 7, 2024
1 check passed
@ehllie ehllie deleted the lsp-hover branch February 7, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ehllie @jfecher