Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid jump while zoom #1440

Open
2 tasks done
TheZooKeeper opened this issue Nov 16, 2020 · 8 comments
Open
2 tasks done

Grid jump while zoom #1440

TheZooKeeper opened this issue Nov 16, 2020 · 8 comments
Assignees

Comments

@TheZooKeeper
Copy link

TheZooKeeper commented Nov 16, 2020

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

When zooming in and out using ctrl+scroll wheel, the screen position will perform a big jump if ctrl is let up before the scroll wheel is done moving. It is important to note that the jump only occurs if the scroll wheel moves before the grid is finished redrawing.

  • draw.io version 13.9.8

  • OS: Windows 10 Pro 1909

  • Browser Chrome

  • Version 86.0.4240.193

@sonebu
Copy link

sonebu commented Mar 15, 2021

I can confirm this still exists in draw.io version 14.4.3

My guess is that this is related to this place and/or this place in the source code. However, this feels like it could also be a timing issue of some sort and I'm not sure if that can completely be fixed in a reliable manner without major changes (like the order in which the "main loop" checks these conditions probably matters since they take up finite time). Maybe a small fix could be delaying the falling edge of the isZoomWheelEvent a little bit after the ctrl key is released?

Overall -> seems to me like the main problem is that draw.io switches from "let's scroll-zoom" to "let's scroll-translate-over-the-document" too fast so the lack of synchronization between the user's two hands comes into the picture and draw.io scrolls like crazy (the jumps weren't random as far as I could gather, they always tend to happen in the direction of the scrolling when the ctrl key is released)

By the way I'm a complete noob in JS and the experiments I made are not air-tight, so please correct me if anything above is wrong.

@lumeche

This comment has been minimized.

@thesuavehog

This comment was marked as off-topic.

@stale
Copy link

stale bot commented Jul 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. See the FAQ for more information.

@stale stale bot added the wontfix label Jul 13, 2022
@stale stale bot closed this as completed Jul 20, 2022
@iikuzmychov
Copy link

This issue is NOT stale!

@alderg alderg reopened this Jun 11, 2023
@stale stale bot removed the wontfix label Jun 11, 2023
@alderg alderg self-assigned this Jun 11, 2023
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. See the FAQ for more information.

@github-actions github-actions bot added the wontfix stale bot automatic label label Jun 14, 2024
@iikuzmychov
Copy link

Still not stale

@davidjgraph davidjgraph removed the wontfix stale bot automatic label label Jun 14, 2024
@ErikSwan
Copy link

ErikSwan commented Jan 2, 2025

It seems like this could potentially be related to #212.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants