Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bucket_prefix parameter not taken into account #318

Open
gregoryb opened this issue Jan 31, 2024 · 9 comments
Open

bucket_prefix parameter not taken into account #318

gregoryb opened this issue Jan 31, 2024 · 9 comments

Comments

@gregoryb
Copy link

I start my server (Keycloak) with the following parameters
-Djgroups.s3.region_name=eu-west-1 -Djgroups.s3.bucket_name=mybucket -Djgroups.s3.bucket_prefix=keycloak/

The ISPN directory is created at the root of the bucket.

I'm using jgroups-aws-2.0.1.Final.jar

@belaban
Copy link
Member

belaban commented Feb 1, 2024

Do you set jgroups.s3.bucket_prefix in the config, e.g.
<S3_PING bucket_prefix="${jgroups.s3.bucket_prefix:ispn}"... />?
I suspect that bucket_prefix is null. If you can debug this and set a breakpoint in S3_PING.init(), you'd know

@gregoryb
Copy link
Author

gregoryb commented Feb 1, 2024

I don't use config files. Only parameters with default values like in my initial post.

ISPN default directory is correctly created in mybucket by without the prefix.

Here is the log:
using Amazon S3 ping in region eu-west-1 with bucket 'mybucket' and prefix ''

I'm not a JAVA guy... complicated to debug this inside keycloak launch.

@belaban
Copy link
Member

belaban commented Feb 1, 2024

According to the log above, bucket_prefix is null, so it won't get created. Somewhere there is a config file (keycloak, infinispan), and that file must have your system props, or else setting system props is useless...

@rhusar
Copy link
Member

rhusar commented Feb 1, 2024

According to the log above, bucket_prefix is null, so it won't get created. Somewhere there is a config file (keycloak, infinispan), and that file must have your system props, or else setting system props is useless...

Correct, this project doesn't define these (e.g. jgroups.s3.bucket_name) - these must be defined in the stack.

@gregoryb Can you post what and how are you running?

@rhusar
Copy link
Member

rhusar commented Feb 1, 2024

@belaban Should we perhaps consider making these configurable via environmental properties so as to 'standardize' the configuration across consumers?

@belaban
Copy link
Member

belaban commented Feb 1, 2024

@rhusar Yes, we can do this, but if Infinispan defines different system props for the same attributes, e.g. in their own config files, then this is moot.

@rhusar
Copy link
Member

rhusar commented Feb 5, 2024

According to the log above, bucket_prefix is null, so it won't get created. Somewhere there is a config file (keycloak, infinispan), and that file must have your system props, or else setting system props is useless...

Correct, this project doesn't define these (e.g. jgroups.s3.bucket_name) - these must be defined in the stack.

@gregoryb Can you post what and how are you running?

@gregoryb Any update on this ^^^ ?

@gregoryb
Copy link
Author

gregoryb commented Feb 5, 2024

I described the issue on keycloak repository:
keycloak/keycloak#26703

I don't know where is the best place for this as it's related to a Keycloak configuration.
I don't know what more I can do to help

@belaban
Copy link
Member

belaban commented Feb 6, 2024

@rhusar Great idea: +1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants