Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Keycloak 23 #24352

Closed
mraible opened this issue Nov 23, 2023 · 7 comments · Fixed by #24403
Closed

Upgrade to Keycloak 23 #24352

mraible opened this issue Nov 23, 2023 · 7 comments · Fixed by #24403
Labels
area: enhancement 🔧 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: keycloak $100 https://www.jhipster.tech/bug-bounties/
Milestone

Comments

@mraible
Copy link
Contributor

mraible commented Nov 23, 2023

Overview of the feature request

https://www.keycloak.org/2023/11/keycloak-2300-released.html

Motivation for or Use Case

It might be cool to configure passkeys by default now that they're supported.

Related issues or PR

#23098

@DanielFran DanielFran added area: enhancement 🔧 theme: keycloak $100 https://www.jhipster.tech/bug-bounties/ $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ and removed area: triage theme: undefined labels Nov 23, 2023
@DanielFran
Copy link
Member

cc @vishal423 @BrayanMnz

@mraible mraible added this to the 8.1.0 milestone Nov 27, 2023
theycallmeducks added a commit to theycallmeducks/generator-jhipster that referenced this issue Nov 27, 2023
upgrade the docker and kubernetes builds to use Keycloak 23.0.0,
see https://www.keycloak.org/2023/11/keycloak-2300-released.html

Fix jhipster#24352
theycallmeducks added a commit to theycallmeducks/generator-jhipster that referenced this issue Nov 27, 2023
upgrade the docker and kubernetes builds to use Keycloak 23.0.0,
see https://www.keycloak.org/2023/11/keycloak-2300-released.html

Fix jhipster#24352
theycallmeducks added a commit to theycallmeducks/generator-jhipster that referenced this issue Nov 27, 2023
upgrade the docker and kubernetes builds to use Keycloak 23.0.0,
see https://www.keycloak.org/2023/11/keycloak-2300-released.html

Fix jhipster#24352
@theycallmeducks
Copy link
Contributor

All checks passing in CI. Other than upgrading the version number, there were changes to some config file syntax. Similar changes were made when jhipster-lite was upgraded to Keycloak 23.0.0 bf048f8

@mraible

@mraible
Copy link
Contributor Author

mraible commented Nov 27, 2023

Thanks for the PR @theycallmeducks! The only thing that I can think of that might be an issue is they keycloak.yml.ejs that's used for Kubernetes. This blog post show how it's used.

@BrayanMnz
Copy link
Contributor

@theycallmeducks There were no changes in the realm?

theycallmeducks added a commit to theycallmeducks/generator-jhipster that referenced this issue Nov 28, 2023
upgrade the docker and kubernetes builds to use Keycloak 23.0.0,
see https://www.keycloak.org/2023/11/keycloak-2300-released.html

Fix jhipster#24352
@BrayanMnz
Copy link
Contributor

Let's update this to use the 23.0.1 already released. @theycallmeducks

@mraible
Copy link
Contributor Author

mraible commented Nov 29, 2023

I talked with @indiepopart, and she said there's a file that hasn't been updated.

One of the Kubernetes templates has a copy of the realm and should be updated generators/kubernetes/templates/keycloak/keycloak-configmap.yml.ejs. I am not sure how to avoid the copy at this moment.

theycallmeducks added a commit to theycallmeducks/generator-jhipster that referenced this issue Nov 29, 2023
upgrade the docker and kubernetes builds to use Keycloak 23.0.1,
see https://www.keycloak.org/2023/11/keycloak-2301-released.html

Fix jhipster#24352
theycallmeducks added a commit to theycallmeducks/generator-jhipster that referenced this issue Nov 29, 2023
upgrade the docker and kubernetes builds to use Keycloak 23.0.1,
see https://www.keycloak.org/2023/11/keycloak-2301-released.html

Fix jhipster#24352
theycallmeducks added a commit to theycallmeducks/generator-jhipster that referenced this issue Nov 29, 2023
upgrade the docker and kubernetes builds to use Keycloak 23.0.1,
see https://www.keycloak.org/2023/11/keycloak-2301-released.html

Fix jhipster#24352
theycallmeducks added a commit to theycallmeducks/generator-jhipster that referenced this issue Nov 30, 2023
upgrade the docker and kubernetes builds to use Keycloak 23.0.1,
see https://www.keycloak.org/2023/11/keycloak-2301-released.html

Fix jhipster jhipster#24352
@theycallmeducks
Copy link
Contributor

Ok, this PR is once again ready for review once tests finish. Completely new to JHipster and and Keycloak, so thank you for the help in understanding the requirements and changes necessary for the story.

The realm changes were the addition of
localizationTexts : KEYCLOAK-20343
webAuthnPolicyExtraOrigins : KEYCLOAK-23155
webAuthnPolicyPasswordlessExtraOrigins : KEYCLOAK-23155.

The PR now upgrades Keycloak to 23.0.1, see https://www.keycloak.org/2023/11/keycloak-2301-released.html for the list of enhancements and bugs added in this release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: enhancement 🔧 $$ bug-bounty $$ https://www.jhipster.tech/bug-bounties/ theme: keycloak $100 https://www.jhipster.tech/bug-bounties/
Projects
None yet
4 participants