Liquibase: Update entity constraint changelog producing wrong baseColumnName for ManyToMany relationships

[OmarHawk]

Overview of the issue

When we added a new ManyToMany relationship to existing tables, the constraints being generated differ from when this is part of the initial generation - and it produces invalid constraints.

Just compare these two lines (they should be kind of equal, as it is the same thing that is being generated):
Correct (uses entity.entityTableName as part of the baseColumnNames):

generator-jhipster/generators/liquibase/templates/src/main/resources/config/liquibase/changelog/added_entity_constraints.xml.ejs

Line 56 in 27ff64a

<addForeignKeyConstraint baseColumnNames="<%= entity.primaryKey.fields.map(field => entity.entityTableName + '_' + field.columnName).join(', ') %>"

Wrong (uses relationship.columnName as part of the baseColumnNames)

generator-jhipster/generators/liquibase/templates/src/main/resources/config/liquibase/changelog/updated_entity_constraints.xml.ejs

Line 137 in 27ff64a

<addForeignKeyConstraint baseColumnNames="<%= entity.primaryKey.fields.map(field => relationship.columnName + '_' + field.columnName).join(', ') %>"

Motivation for or Use Case

Saving doesn't work properly using that kind of constraint.

Reproduce the error

Related issues

Suggest a Fix

Align the two files. I'll prepare a PR.

JHipster Version(s)

8.6.0

JHipster configuration

Entity configuration(s) entityName.json files generated in the .jhipster directory

Browsers and Operating System

• Checking this box is mandatory (this is just to show you read everything)