Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cypress recommanded selectors to dataSelector #11158

Closed
DamnClin opened this issue Oct 19, 2024 · 0 comments · Fixed by #11302
Closed

Add Cypress recommanded selectors to dataSelector #11158

DamnClin opened this issue Oct 19, 2024 · 0 comments · Fixed by #11302
Labels
area: enhancement 🔧 area: good first issue theme: client

Comments

@DamnClin
Copy link
Collaborator

Cypress have recommendations for data selectors

We should update src/main/resources/generator/client/common/cypress/utils/DataSelector.ts to add them, probably something like:

export const dataSelector = (selector: string): string => `[data-selector="${selector}"],[data-testid="${selector}"],[data-test="${selector}"]`;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: enhancement 🔧 area: good first issue theme: client
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cypress: Best practices for selectors qmonmert/jhipster-lite
1 participant
@DamnClin