Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 5.2.4 should be breaking change release #219

Open
0llirocks opened this issue Apr 19, 2023 · 1 comment
Open

Version 5.2.4 should be breaking change release #219

0llirocks opened this issue Apr 19, 2023 · 1 comment

Comments

@0llirocks
Copy link

I don't know if you are still using semantic versioning after you changed your versioning strategy to match supported rails version, but version 5.2.4 breaks existing code since you removed jQuery (which is a good thing).

The following line doesn't work anymore and must be changed

Old:
//= require filterrific/filterrific-jquery

New:
//= require filterrific/filterrific

From my point of view, this is a breaking change and should not be a patch release.
@MisterGetman
Copy link

Indeed! //= require filterrific/filterrific-jquery gave me an error:

ActionView::Template::Error (couldn't find file 'filterrific/filterrific-jquery' with type 'application/javascript'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0llirocks @MisterGetman