Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 PHP 8.4 deprecations #568

Open
1 task done
ToshY opened this issue Jan 27, 2025 · 0 comments
Open
1 task done

🐛 PHP 8.4 deprecations #568

ToshY opened this issue Jan 27, 2025 · 0 comments
Labels

Comments

@ToshY
Copy link
Contributor

ToshY commented Jan 27, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Bumping to PHP 8.4, noticed deprecations, using jikan-me/jikan: 5.0.0-dev.

2025-01-27T11:45:32.094251875Z Deprecated: Jikan\MyAnimeList\MalClient::__construct(): Implicitly marking parameter $httpClient as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/jikan-me/jikan/src/MyAnimeList/MalClient.php on line 45
2025-01-27T11:45:32.094757890Z Deprecated: Jikan\Http\HttpClientWrapper::request(): Implicitly marking parameter $content as nullable is deprecated, the explicit nullable type must be used instead in /app/vendor/jikan-me/jikan/src/Http/HttpClientWrapper.php on line 28

There are probably more, just haven't encountered them yet.

Expected Behavior

No deprecation issues.

Steps To Reproduce

No response

Environment

Anything else?

No response

@ToshY ToshY added the bug label Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant