Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do open nodes have parents? #3

Open
o-alex opened this issue Aug 26, 2014 · 1 comment
Open

Do open nodes have parents? #3

o-alex opened this issue Aug 26, 2014 · 1 comment

Comments

@o-alex
Copy link
Collaborator

o-alex commented Aug 26, 2014

DirectMsgNetty class - getHeaderSize() method - line 66
the method, I think wrongly assumes everyone has VodConfig.PM_NUM_PARENTS, but open nodes have no parents. I suspect there should be a check and add that to header size only if node is nated

@jimdowling
Copy link
Owner

This isn't a blocking issue, as getHeaderSize() is only used to pre-allocate the size of the Buffer in Netty. If the buffer is a bit larger for open nodes, it only means more memory has been allocated than needed for the object. That extra memory shouldnt be sent out with the packet - it shouldnt affect packet size.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants