You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
DirectMsgNetty class - getHeaderSize() method - line 66
the method, I think wrongly assumes everyone has VodConfig.PM_NUM_PARENTS, but open nodes have no parents. I suspect there should be a check and add that to header size only if node is nated
The text was updated successfully, but these errors were encountered:
This isn't a blocking issue, as getHeaderSize() is only used to pre-allocate the size of the Buffer in Netty. If the buffer is a bit larger for open nodes, it only means more memory has been allocated than needed for the object. That extra memory shouldnt be sent out with the packet - it shouldnt affect packet size.
DirectMsgNetty class - getHeaderSize() method - line 66
the method, I think wrongly assumes everyone has VodConfig.PM_NUM_PARENTS, but open nodes have no parents. I suspect there should be a check and add that to header size only if node is nated
The text was updated successfully, but these errors were encountered: