Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: replica = 1 doesnt work? #167

Open
brokeDude2901 opened this issue Aug 11, 2022 · 2 comments
Open

bug: replica = 1 doesnt work? #167

brokeDude2901 opened this issue Aug 11, 2022 · 2 comments

Comments

@brokeDude2901
Copy link

It seem discoart doesn't respect replica = 1 settings in .yml file:

jtype: Flow
with:
  protocol: http
  monitoring: false
  cors: true
  port: 51001
  port_monitoring: 51002  # prometheus monitoring port
  env:
    JINA_LOG_LEVEL: debug
    DISCOART_DISABLE_IPYTHON: 1
    DISCOART_DISABLE_RESULT_SUMMARY: 1
    WANDB_MODE: disabled
executors:
  - name: discoart
    uses: DiscoArtExecutor
    replicas: 1  # change this if you have larger VRAM
    floating: false  # new feature in Jina 3.7, set this to true allows `create` to be immediately returned without waiting the response on the client
  - name: poller
    uses: ResultPoller
@hanxiao
Copy link
Member

hanxiao commented Aug 11, 2022

can't reproduce

@brokeDude2901
Copy link
Author

jtype: Flow
with:
  protocol: http
  monitoring: false
  cors: true
  port: 51001
  port_monitoring: 51002  # prometheus monitoring port
  env:
    JINA_LOG_LEVEL: debug
    DISCOART_DISABLE_IPYTHON: 1
    DISCOART_DISABLE_RESULT_SUMMARY: 1
    WANDB_MODE: disabled
executors:
  - name: discoart
    uses: DiscoArtExecutor
    replicas: 1  # change this if you have larger VRAM
    floating: false  # new feature in Jina 3.7, set this to true allows `create` to be immediately returned without waiting the response on the client
  - name: poller
    uses: ResultPoller

Not sure if this is bug or intended:
case 1: replicas settings is set to 1 in .yml
From one machine:

  • First python script: d = c.post("/create",parameters={... })
  • Second python script: d = c.post("/create",parameters={... })
    In discoart server (docker):
  • shows 2 running progress bar of 2 'INFO - creating artworks' ...
    Should discoart wait for the first create to complete before starting the 2nd create (like dalle-flow)?

case 2: replicas settings is set to 2 in .yml
From one machine:

  • First python script: d = c.post("/create",parameters={... })
  • Second python script: d = c.post("/create",parameters={... })
  • Third python script: d = c.post("/create",parameters={... })
    In discoart server (docker):
  • shows 3 running progress bar of 3 'INFO - creating artworks' ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants