Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to build Jinja2Cpp with latest version of CMake - Have errors about Nlohmann::JSON and RapidJSON #202

Closed
DragonOsman opened this issue Aug 15, 2020 · 5 comments

Comments

@DragonOsman
Copy link

I tried to generate project files for Jinja2Cpp using the latest version of CMake, 3.18.1. I tried with both clang-cl.exe and cl.exe as the compiler for VS2019. In both cases, I got this CMakeError:

-- RapidJSON found. Headers: C:/Jinja2Cpp/thirdparty/json/rapid/include
fatal: Needed a single revision
Unable to find current revision in submodule path 'thirdparty/json/nlohmann'
CMake Error at thirdparty/internal_deps.cmake:41 (add_subdirectory):
  The source directory

    C:/Jinja2Cpp/thirdparty/json/nlohmann

  does not contain a CMakeLists.txt file.
Call Stack (most recent call first):
  thirdparty/thirdparty-external-boost.cmake:3 (include)
  thirdparty/CMakeLists.txt:44 (include)
  CMakeLists.txt:172 (include)

Please help me out here if possible. Is there a way to resolve this?

@satarsa
Copy link

satarsa commented Aug 16, 2020

I have the same issues with both VC2019 and VC2017 after their upgrade up to 16.7.1 and 15.9.26 respectively... Unfortunately, I guess, it is not going to be fixed...

@DragonOsman
Copy link
Author

I'm also having the problem after upgrade to VS2019 version 16.7.1.

Should we mention it on MSDN Forums? I have the problem on both Developer Command Prompt for VS2019 and also in the VS2019 IDE with its CMake support.

@satarsa
Copy link

satarsa commented Aug 16, 2020

May be this pull request would help?
#197
Could you try? I'm far from work for now, I'll be able to test it only after a few days.

@DragonOsman
Copy link
Author

I'm not using a Conan package, though. I'm trying to build it directly. So I don't think that will help me. Thanks, though.

@DragonOsman
Copy link
Author

I was able to solve that by re-cloning the library and then updating submodules.

But now I have a problem where I get build errors (I managed to successfully generate project files). I'll open a new issue for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants