From 5d96fdee202d6df891fe23db9287c637e09b611a Mon Sep 17 00:00:00 2001 From: Goo Nine Date: Thu, 12 Dec 2024 14:56:59 -0800 Subject: [PATCH] update jup api url, update inline price showing for individual mint accounts so it now reliably works and presents a little beter styling-wise --- components/TreasuryAccount/AccountItem.tsx | 63 ++++++++++++++++------ hooks/queries/jupiterPrice.ts | 2 +- utils/treasuryTools.tsx | 2 + 3 files changed, 50 insertions(+), 17 deletions(-) diff --git a/components/TreasuryAccount/AccountItem.tsx b/components/TreasuryAccount/AccountItem.tsx index 4fdd1e30c1..643db0b188 100644 --- a/components/TreasuryAccount/AccountItem.tsx +++ b/components/TreasuryAccount/AccountItem.tsx @@ -3,6 +3,8 @@ import { getTreasuryAccountItemInfoV2 } from '@utils/treasuryTools' import { AssetAccount } from '@utils/uiTypes/assets' import TokenIcon from '@components/treasuryV2/icons/TokenIcon' import { useTokenMetadata } from '@hooks/queries/tokenMetadata' +import { useJupiterPriceByMintQuery } from '../../hooks/queries/jupiterPrice' +import BigNumber from 'bignumber.js' const AccountItem = ({ governedAccountTokenAccount, @@ -10,55 +12,84 @@ const AccountItem = ({ governedAccountTokenAccount: AssetAccount }) => { const { + decimalAdjustedAmount, amountFormatted, logo, name, symbol, - displayPrice, } = getTreasuryAccountItemInfoV2(governedAccountTokenAccount) + const { data: priceData } = useJupiterPriceByMintQuery( + governedAccountTokenAccount.extensions.mint?.publicKey + ) + const { data } = useTokenMetadata( governedAccountTokenAccount.extensions.mint?.publicKey, !logo ) const symbolFromMeta = useMemo(() => { - return data?.symbol - }, [data?.symbol]) + // data.symbol is kinda weird + //Handle null characters, whitespace, and ensure fallback to symbol + const cleanSymbol = data?.symbol + ?.replace(/\0/g, '') // Remove null characters + ?.replace(/\s+/g, ' ') // Normalize whitespace to single spaces + ?.trim() // Remove leading/trailing whitespace + + return cleanSymbol || symbol || '' + }, [data?.symbol, symbol]) + + const displayPrice = useMemo(() => { + if (!decimalAdjustedAmount || !priceData?.result?.price) return '' + + try { + const totalPrice = decimalAdjustedAmount * priceData.result.price + return new BigNumber(totalPrice).toFormat(0) + } catch (error) { + console.error('Error calculating display price:', error) + return '' + } + }, [priceData, decimalAdjustedAmount]) return (
{logo ? ( { - currentTarget.onerror = null // prevents looping + currentTarget.onerror = null currentTarget.hidden = true }} + alt={`${name} logo`} /> ) : ( + className="flex-shrink-0 h-6 w-6 mr-2.5 mt-0.5 fill-current" + /> )}
-
{name}
+
+ {name || 'Unknown Token'} +
-
- {amountFormatted} {symbolFromMeta ? symbolFromMeta : symbol} +
+
+ {amountFormatted} + {symbolFromMeta && ` ${symbolFromMeta}`} +
+ {displayPrice && ( +
+ (${displayPrice}) +
+ )}
- {displayPrice ? ( -
≈${displayPrice}
- ) : ( - '' - )}
) } -export default AccountItem +export default AccountItem \ No newline at end of file diff --git a/hooks/queries/jupiterPrice.ts b/hooks/queries/jupiterPrice.ts index 0c153837cc..915bd5d84c 100644 --- a/hooks/queries/jupiterPrice.ts +++ b/hooks/queries/jupiterPrice.ts @@ -2,7 +2,7 @@ import { PublicKey } from '@solana/web3.js' import { useQuery } from '@tanstack/react-query' import queryClient from './queryClient' -const URL = 'https://price.jup.ag/v4/price' +const URL = 'https://api.jup.ag/price/v2' /* example query GET https://price.jup.ag/v4/price?ids=SOL diff --git a/utils/treasuryTools.tsx b/utils/treasuryTools.tsx index dcb18f659f..6f57cd095d 100644 --- a/utils/treasuryTools.tsx +++ b/utils/treasuryTools.tsx @@ -59,6 +59,7 @@ export const getTreasuryAccountItemInfoV2 = (account: AssetAccount) => { : '' return { + decimalAdjustedAmount: amount, accountName, amountFormatted, logo, @@ -67,5 +68,6 @@ export const getTreasuryAccountItemInfoV2 = (account: AssetAccount) => { info, symbol, totalPrice, + } }