Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build / release #12

Open
benbro opened this issue May 24, 2015 · 4 comments
Open

Build / release #12

benbro opened this issue May 24, 2015 · 4 comments

Comments

@benbro
Copy link

benbro commented May 24, 2015

Can you please add a build task with grunt or gulp that creates a single debug and minified files of the whole code and dependencies (sdp-transform) under a namespace?

That will make it easier to use in the browser with projects that are not using require().

@gpolitis
Copy link
Member

Sure, this sounds like a great idea, I'll have a look.

@benbro
Copy link
Author

benbro commented May 24, 2015

grunt and gulp are popular build tools.
browserify and webpack are popular tools to use node modules in the browser.

gulp+webpack seems to be the new 'standard'.
https://github.com/shama/gulp-webpack

It will be useful to expose PeerConnectionAdapter.
It's missing:
onicecandidate
onconnecting
onopen
onaddstream
onremovestream
onnegotiationneeded

@gpolitis
Copy link
Member

I feel more familiar with grunt but I like how gulp favors code over configuration, so I wouldn't exclude it if somebody pointed me to an almost equivalent gulp file of this.

About the PeerConnectionAdapter in the README.md, it's only meant to be used as an example illustrating how you could integrate sdp-interop into your app, so I don't see how it's missing the events that you list. But maybe I misunderstood what you're saying?

@benbro
Copy link
Author

benbro commented May 24, 2015

grunt vs gulp is not really important if you are familiar with one of them.
I wasn't so I did a bit of research.

I thought that it could be nice to expose PeerConnectionAdapter instead of the interop.
In the example in the README I think it might do double translation sometimes.
Not really important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants