Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for renamed and modified #37

Open
vsoch opened this issue Jun 19, 2021 · 2 comments
Open

Support for renamed and modified #37

vsoch opened this issue Jun 19, 2021 · 2 comments

Comments

@vsoch
Copy link

vsoch commented Jun 19, 2021

Hi! I'm loving using your action, and just ran into a case where I had a file renamed and modified. I'm currently using the added_modified output, and I was puzzled that it didn't show up in that set. If the name added_modified indicates added OR modified, I'm wondering why the renamed file does not appear there? I don't think it means added and modified because it definitely triggers for files that are existing and just changed.

While I would expect all renamed files to be under renamed, this set alone doesn't give me enough information to tell me if a file is renamed and modified. For the subset of renamed files that are modified, I would think they would appear in added_modified? I'm not sure if this is a bug but please let me know if there is another way to get that list!

@n8felton
Copy link

Just adding that I too would like to see either renamed added into added_modified, or a new option that includes everything except removed.

@TannerGilbert
Copy link

This functionality exists in @Ana06's fork Ana06/get-changed-files. For more information, read the README of check out the commit that added the feature: 47aa8c6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants