Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Support SSH authentication through GIT_SSH_COMMAND #4937

Open
ccll opened this issue Nov 21, 2024 · 1 comment
Open

FR: Support SSH authentication through GIT_SSH_COMMAND #4937

ccll opened this issue Nov 21, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@ccll
Copy link

ccll commented Nov 21, 2024

Is your feature request related to a problem? Please describe.

We use Coder as remote containerized development environment for the team.

Coder will inject a custom GIT_SSH_COMMAND env var to each user's own workspace container, so the user can authenticate to our private Git server through SSH, as long as the user have added their public key in the Coder Web UI.

The env var looks like this:

GIT_SSH_COMMAND=/tmp/coder.lxnhG0/coder gitssh --

Recently some teammate proposed jj as an advanced alternative to plain git, and we liked it! We wanted to use it in our workflow.

The problem is that jj seems not respecting GIT_SSH_COMMAND so we can't push/pull from our Git server from within the Coder container.

Describe the solution you'd like

Let jj respect GIT_SSH_COMMAND.

Describe alternatives you've considered
N/A

Additional context
N/A

@martinvonz
Copy link
Member

We currently use libgit2 in jj git push. We might switch to subprocessing to regular git push instead. That would solve a lot of problems with compatibility. It would probably solve this issue too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants