-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jj show -T
always generates diff
#5036
Comments
|
I've been using exactly that in the meantime and it does work, although I assumed that
|
Well, |
If |
@yuja, could we make the diff part of the template? We have support for that these days (thanks to you), so it seems like we should be able to do that. |
I think it's a historical thing. In the past, we didn't have the ability to include diffs as part of the template (as Martin said), so for I suspect nobody has really asked for it before this request, because nobody really wanted anything else. |
That's doable (ignoring word wrapping issues and CLI flags), but it would be surprising if |
I personally find it confusing as I can't think of any situation I'd want to use a template to change the output of the metadata yet still show the diff. If Although it still makes sense to me as a user that |
To me, One possible use case of Another idea is to make |
Isn't that what |
Yeah, kind of. |
I'm fine with removing support for |
Description
When I use
-T
withjj show
, the diff is always generated and printed after the template output.Steps to Reproduce the Problem
In a jj repository with changes to the working copy.
jj show -T 'self.empty()'
Expected Behavior
Outputs only
true
orfalse
.Actual Behavior
Outputs
true
orfalse
followed by the entire diff of changes in the working copy.Specifications
The text was updated successfully, but these errors were encountered: