Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jj commit -i fails to remove file #5150

Closed
doudou opened this issue Dec 19, 2024 · 3 comments
Closed

jj commit -i fails to remove file #5150

doudou opened this issue Dec 19, 2024 · 3 comments

Comments

@doudou
Copy link

doudou commented Dec 19, 2024

Description

I have a working copy with two files removed. If I try to create a commit with the removal only using commit -i, the created commit is empty.

Steps to Reproduce the Problem

image

In the jj commit -i window, I selected the test/a changes. I did add some content to both a and b files using vi (random text)

Doing a jj commit test/a works as expected

Expected Behavior

The commit created using commit -i should contain the file removal.

Actual Behavior

The commit created using commit -i is empty (as indicated)

Specifications

  • Platform: Ubuntu 20.04
  • Version: jj 0.24.0
@mrnossiom
Copy link
Member

mrnossiom commented Dec 19, 2024

I was able to reproduce without a folder.

Commands extracted from the image (removed the folder step) :

# in a empty temporary folder
jj git init
hx a
hx b
jj commit -m "first"
rm a
jj st
jj commit -i -m "second"
ls test

@martinvonz
Copy link
Member

Sounds like #3702

@martinvonz
Copy link
Member

That's our most upvoted bug, btw (but there are more-updated FRs). If anyone wants to help with that, it would be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants