From cb4843ad82b02126c60db020c6294ec41c4a2413 Mon Sep 17 00:00:00 2001 From: blazh Date: Tue, 10 Sep 2024 20:30:41 +0200 Subject: [PATCH] chore: rm onMenuStateChange for menu component --- packages/react-app-revamp/components/Share/index.tsx | 5 +---- .../components/_pages/Contest/Contest/index.tsx | 12 ++---------- .../components/SortDropdown/index.tsx | 5 +---- .../Contest/components/ProposalStatistics/index.tsx | 9 ++------- .../layouts/LayoutViewContest/index.tsx | 10 ++-------- 5 files changed, 8 insertions(+), 33 deletions(-) diff --git a/packages/react-app-revamp/components/Share/index.tsx b/packages/react-app-revamp/components/Share/index.tsx index bc9fbabe6..21501f004 100644 --- a/packages/react-app-revamp/components/Share/index.tsx +++ b/packages/react-app-revamp/components/Share/index.tsx @@ -18,10 +18,9 @@ interface ShareDropdownProps { contestName: string; contestAddress: string; chain: string; - onMenuStateChange?: (isOpen: boolean) => void; } -const ShareDropdown: FC = ({ contestName, contestAddress, chain, onMenuStateChange }) => { +const ShareDropdown: FC = ({ contestName, contestAddress, chain }) => { const [isCopied, setIsCopied] = useState(false); useEffect(() => { @@ -42,8 +41,6 @@ const ShareDropdown: FC = ({ contestName, contestAddress, ch return ( {({ open }) => { - onMenuStateChange?.(open); - return ( <> diff --git a/packages/react-app-revamp/components/_pages/Contest/Contest/index.tsx b/packages/react-app-revamp/components/_pages/Contest/Contest/index.tsx index a1e257de6..4021e0338 100644 --- a/packages/react-app-revamp/components/_pages/Contest/Contest/index.tsx +++ b/packages/react-app-revamp/components/_pages/Contest/Contest/index.tsx @@ -37,7 +37,6 @@ const ContestTab = () => { const qualifiedToSubmit = currentUserQualifiedToSubmit && currentUserProposalCount < contestMaxNumberSubmissionsPerUser; const isMobile = useMediaQuery({ maxWidth: 768 }); - const [blurProposals, setBlurProposals] = useState(false); const isInPwaMode = window.matchMedia("(display-mode: standalone)").matches; const { contestState } = useContestStateStore(state => state); const isContestCanceled = contestState === ContestStateEnum.Canceled; @@ -98,18 +97,11 @@ const ContestTab = () => {
{contestStatus !== ContestStatus.ContestOpen && !isContestLoading && ( - setBlurProposals(value)} - /> + )} {!isContestLoading && !isListProposalsLoading && isContestSuccess && isListProposalsSuccess && ( -
+
)} diff --git a/packages/react-app-revamp/components/_pages/Contest/components/ProposalStatistics/components/SortDropdown/index.tsx b/packages/react-app-revamp/components/_pages/Contest/components/ProposalStatistics/components/SortDropdown/index.tsx index 20bb7a001..6cb6a6efc 100644 --- a/packages/react-app-revamp/components/_pages/Contest/components/ProposalStatistics/components/SortDropdown/index.tsx +++ b/packages/react-app-revamp/components/_pages/Contest/components/ProposalStatistics/components/SortDropdown/index.tsx @@ -16,10 +16,9 @@ const options = [ interface SortProposalsDropdownProps { defaultValue: string; onChange?: (value: string) => void; - onMenuStateChange?: (isOpen: boolean) => void; } -const SortProposalsDropdown: FC = ({ defaultValue, onChange, onMenuStateChange }) => { +const SortProposalsDropdown: FC = ({ defaultValue, onChange }) => { const [selectedValue, setSelectedValue] = useState(defaultValue); const menuRef = useRef(null); @@ -33,8 +32,6 @@ const SortProposalsDropdown: FC = ({ defaultValue, o return ( {({ open }) => { - onMenuStateChange?.(open); - return ( <> diff --git a/packages/react-app-revamp/components/_pages/Contest/components/ProposalStatistics/index.tsx b/packages/react-app-revamp/components/_pages/Contest/components/ProposalStatistics/index.tsx index 5771a6da9..31ebb8e54 100644 --- a/packages/react-app-revamp/components/_pages/Contest/components/ProposalStatistics/index.tsx +++ b/packages/react-app-revamp/components/_pages/Contest/components/ProposalStatistics/index.tsx @@ -12,10 +12,9 @@ import { chains } from "@config/wagmi"; interface ProposalStatisticsProps { contestStatus: ContestStatus; - onMenuStateChange: (isOpen: boolean) => void; } -const ProposalStatistics: FC = ({ contestStatus, onMenuStateChange }) => { +const ProposalStatistics: FC = ({ contestStatus }) => { const asPath = usePathname(); const { chainName, address } = extractPathSegments(asPath ?? ""); const chainId = chains.filter(chain => chain.name.toLowerCase() === chainName.toLowerCase())[0]?.id; @@ -62,11 +61,7 @@ const ProposalStatistics: FC = ({ contestStatus, onMenu
{submissionsCount > 1 ? ( - + ) : null}
diff --git a/packages/react-app-revamp/layouts/LayoutViewContest/index.tsx b/packages/react-app-revamp/layouts/LayoutViewContest/index.tsx index fef9ae31b..a46bcb494 100644 --- a/packages/react-app-revamp/layouts/LayoutViewContest/index.tsx +++ b/packages/react-app-revamp/layouts/LayoutViewContest/index.tsx @@ -62,7 +62,6 @@ const LayoutViewContest = ({ children }: { children: React.ReactNode }) => { const [tab, setTab] = useState(Tab.Contest); const isMobile = useMediaQuery({ maxWidth: 768 }); const bugReportLink = populateBugReportLink(url?.href ?? "", accountAddress ?? "", error ?? ""); - const [fadeBg, setFadeBg] = useState(false); useAccountEffect({ onConnect(data) { @@ -253,12 +252,7 @@ const LayoutViewContest = ({ children }: { children: React.ReactNode }) => { share
) : ( - + )}
{
-
+
setTab(tab)} />