[Proposal] Migrate to fast-check #353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dubzzz
commented
Jun 15, 2021
| key: jsc.elements(['a', 'b', 'c', 'd', 'e', 'f', 'g', 'h']), | ||
| value: jsc.nat, | ||
| }) as any | ||
| const arbitraryCommand = fc.record({ |
There was a problem hiding this comment.
There is a built-in way to deal with commands in fast-check. I could probably migrate the test to it.
dubzzz
commented
Jun 15, 2021
Comment on lines
+7
to
+15
| let numericType = fc | ||
| .double({ | ||
| next: true, | ||
| noDefaultInfinity: true, | ||
| noNaN: true, | ||
| min: -1 / numericTypeMinAccuracy, | ||
| max: 1 / numericTypeMinAccuracy, | ||
| }) | ||
| }) | ||
| .map(d => Math.round(d / numericTypeMinAccuracy) * numericTypeMinAccuracy) |
There was a problem hiding this comment.
Here the arbitrary fc.double was able to find potential issues when used with full resolution. Contrary to jsc.number it can generate any number from -Infinity to +Infinity including -0, Number.MIN_VALUE, Number.EPSILON and others (from small to large values).
dubzzz
commented
Jun 15, 2021
Comment on lines
+235
to
+236
| // If the above expect(...) assertion fails, we won't reach here. | ||
| return true |
There was a problem hiding this comment.
No need for return with fast-check. No return or return true is success. Throw or return false is failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This Pull Request is mostly a proposal to migrate from jsverify to fast-check.
Why?
jsverify's owner stopped the maintenance of the library more than a year ago. In addition, the last real commit to jsverify was on the 6th of September 2019.
Benefits of
fast-checkoverjsverifymap(smapinjsverify).