Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

How to add support .csproj projects #7

Open
doaortu opened this issue Nov 29, 2023 · 2 comments
Open

How to add support .csproj projects #7

doaortu opened this issue Nov 29, 2023 · 2 comments

Comments

@doaortu
Copy link

doaortu commented Nov 29, 2023

Hi, I want to try this plugin but I mostly have .csproj projects.
Could you please give me pointer how to do it myself? I see in init.lua you have some kind detection for .csproj projects, but I think it's not done yet so you comment it out.

What's need to be done to make this plugin work with .csproj projects?
Any pointer would be appreciated.

Thanks.

@jmederosalvarado
Copy link
Owner

The first thing to do is definitely send open project notifications, the same way we do it for sln, when your target is a project.

On multi-csproj projects:

Not sure how the workspace initialized notification will behave in cases where you notify about multiple csproj. This csproj detection code works for one csproj only. The concept of targets in the plugin only takes into account one target per server instance, so trying to attach the same server to multiple projects might require rethinking this. I would say for multiple csproj it's natural to have a sln, so I wouldn't worry about this edge case.

Other things to take into account:

  • The workspace initialized notification will probably work the same with project and solution notifications. But worth watching this when you're testing the implementation.

  • Make sure to remove this check and similar ones (not sure if there are any).

@jmederosalvarado
Copy link
Owner

Let me know if there's anything else I can do to help, I think it should be simple enough, don't get discouraged by the long text :).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants