Skip to content

Latest commit

 

History

History
171 lines (119 loc) · 7.1 KB

cran-comments.md

File metadata and controls

171 lines (119 loc) · 7.1 KB

qrlabelr 0.2.0

This is a minor release. The following changes were made since the release of version 0.1.1:

  • Added 'BrAPI'-compliance features to the 'shiny' app. This implies that users can now query or access data directly from 'BMS' and 'breedbase' databases via the 'QBMS' package.
  • Redesigned the 'Import fieldbook' tab in the 'shiny' app to reflect these new features.
  • Added the 'QBMS' package to the Imports field in the DESCRIPTION file.
  • Added the 'async' package to the Suggests field in the DESCRIPTION file to boost the speed of querying breeding databases.
  • Updated the NAMESPACE accordingly.
  • Fixed a mislabeled object bug in the general-purpose landscape text label option in the 'shiny' app.

qrlabelr 0.1.1

This is a patch release. The following patches have been made to 'qrlabelr' since the release of version 0.1.0:

  • Fixed a font size bug in Treetag label option in 'shiny' app.
  • Added a new argument to the create_label() and gp_label_portrait() functions to allow users to fill multi-row and column pages with labels horizontally (left to right ) or vertically (top to bottom).
  • Added a new argument to the create_label() and gp_label_portrait() functions to allow users the option to draw rectangles around labels or make labels without rectangular borders.
  • Simplified the 'shiny' app by disabling subset functionality on the 'Generate labels' tab.
  • Field plot label option in 'shiny' app and field_label() function can now show unique ID text on the label.
  • Field plot label option in 'shiny' app and field_label() function show no human-readable text if input field book does not have incomplete intra-blocks.
  • Seed prefix in the seed source delineated text position removed to allow users to pass any human-readable text to this position apart from seed source in the field_label() function and 'shiny' app.
  • iBlock ID prefix in the iBlock delineated text position truncated to B in the field_label() function and 'shiny' app.
  • Field plot label option in 'shiny' app now allows users to blank any delineated human-readable text position with NULL text.

R CMD check results from the terminal in R and RStudio

Status: OK

0 errors | 0 warnings | 0 notes

Test environments

R-hub

  • R-hub windows-x86_64-devel (r-devel)
  • R-hub ubuntu-gcc-release (r-release)
  • R-hub fedora-clang-devel (r-devel)

0 errors ✔ | 0 warnings ✔ | 4 notes

R CMD check results in R-hub

❯ On windows-x86_64-devel (r-devel) checking CRAN incoming feasibility ... [19s] NOTE

Maintainer: 'Alexander Wireko Kena [email protected]'

❯ On windows-x86_64-devel (r-devel) checking for non-standard things in the check directory ... NOTE

❯ On windows-x86_64-devel (r-devel) checking for detritus in the temp directory ... NOTE Found the following files/directories: 'lastMiKTeXException'

This NOTE appears to be a bug in the R-hub platform and has been reported by many.

❯ On ubuntu-gcc-release (r-release) checking CRAN incoming feasibility ... [7s/28s] NOTE Maintainer: ‘Alexander Wireko Kena [email protected]’

❯ On ubuntu-gcc-release (r-release), fedora-clang-devel (r-devel) checking examples ... NOTE Examples with CPU (user + system) or elapsed time > 5s user system elapsed make_qrcode 5.918 0.108 6.026

Example runs in less than 3s when tested on windows-x86_64-devel (r-devel).

❯ On ubuntu-gcc-release (r-release), fedora-clang-devel (r-devel) checking HTML version of manual ... NOTE Skipping checking HTML validation: no command 'tidy' found

This NOTE arose from the test environment and cannot be fixed from my end.

❯ On fedora-clang-devel (r-devel) checking CRAN incoming feasibility ... [8s/33s] NOTE Maintainer: ‘Alexander Wireko Kena [email protected]’

GitHub Action workflows

  • {os: macos-latest, r: 'release'}
  • {os: windows-latest, r: 'release'}
  • {os: ubuntu-latest, r: 'devel', http-user-agent: 'release'}
  • {os: ubuntu-latest, r: 'release'}
  • {os: ubuntu-latest, r: 'oldrel-1'}

All tests passed on GitHub.

Changes made since second submission

❯ if statement in examples has been placed inside the \donttest{} as suggested by Beni Altmann.

Changes made since first submission

Following suggestions by Beni Altmann, we have made these changes before resubmitting the package to CRAN:

❯ The 'shiny' package name used in the description field has been placed in single quotes and changed all letters to lowercase.

❯ Extra spaces in the description field of DESCRIPTION removed and formatted to comply with best practices.

❯ Methods used in the package as described by Wu et al. (2020) doi:10.1111/2041-210X.13405> added to the description field.

❯ Added \value and example to run_app.Rd.

❯ All \dontrun{} in examples replaced with \donttest{}. To make examples pass on Windows platforms, we added an if statement to check if tempfile or tempdir exists before running examples.

❯ Messages written to console by functions suppressed except for progress bar.

❯ All examples in vignette write to tempdir() instead of user's home file space.

R CMD check results from the terminal in R

0 errors | 0 warnings | 1 note

  • This is a new release.

Test environments

R-hub

  • R-hub windows-x86_64-devel (r-devel)
  • R-hub ubuntu-gcc-release (r-release)
  • R-hub fedora-clang-devel (r-devel)

0 errors ✔ | 0 warnings ✔ | 7 notes

R CMD check results in R-hub

❯ On windows-x86_64-devel (r-devel) checking CRAN incoming feasibility ... [19s] NOTE

New submission Maintainer: 'Alexander Wireko Kena [email protected]'

❯ On windows-x86_64-devel (r-devel) checking for non-standard things in the check directory ... NOTE

❯ On windows-x86_64-devel (r-devel) checking for detritus in the temp directory ... NOTE Found the following files/directories: 'lastMiKTeXException'

This NOTE appears to be a bug in the R-hub platform and has been reported by many.

❯ On ubuntu-gcc-release (r-release) checking CRAN incoming feasibility ... [7s/28s] NOTE Maintainer: ‘Alexander Wireko Kena [email protected]’

New submission

❯ On ubuntu-gcc-release (r-release), fedora-clang-devel (r-devel) checking examples ... NOTE Examples with CPU (user + system) or elapsed time > 5s user system elapsed make_qrcode 5.918 0.108 6.026

Example runs in less than 3s when tested on windows-x86_64-devel (r-devel).

❯ On ubuntu-gcc-release (r-release), fedora-clang-devel (r-devel) checking HTML version of manual ... NOTE Skipping checking HTML validation: no command 'tidy' found

This NOTE arose from the test environment and cannot be fixed from my end.

❯ On fedora-clang-devel (r-devel) checking CRAN incoming feasibility ... [8s/33s] NOTE Maintainer: ‘Alexander Wireko Kena [email protected]’

New submission

GitHub Action workflows

  • {os: macos-latest, r: 'release'}
  • {os: windows-latest, r: 'release'}
  • {os: ubuntu-latest, r: 'devel', http-user-agent: 'release'}
  • {os: ubuntu-latest, r: 'release'}
  • {os: ubuntu-latest, r: 'oldrel-1'}

All tests passed on GitHub.