-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auto connect option when Octoprint 'Connects' #356
Conversation
Bumps [actions/stale](https://github.com/actions/stale) from 7 to 8. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v7...v8) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…ions/actions/stale-8
Bumps [actions/stale](https://github.com/actions/stale) from 8 to 9. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v8...v9) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
…ions/actions/stale-9 Bump actions/stale from 8 to 9
The duplication also occurs with Let me know what you prefer and I can adjsut code as neeeded... |
One quick note... I didn't modify the GUI to add these variables as I didn't want to mess with your layout -- especially since it is already chock-full... |
Thanks for the heads up. There will also need to be some tweaks to other bits when adding to the UI that require additional tweaks using the settings migration, because none of the configured plugs would have that new property and would cause errors when loading. That's usually handled through the settings_migration. |
Yeah - I saw that but I didn't want to presume when/how you wanted to add a new migration version. BTW, I really am finding this new option very helpful because while I often start new prints by uploading and connecting automatically via Prusa slicer, I also often want to pre-connect either to preheat the bed & tool or to reprint a previously uploaded print. |
This adds feature request #307
Note I had to add the following
config.yaml
settings to allow cusomized enabling.connect_on_connect_request
(modeled afterevent_on_startup_monitoring
)connect_on_connect
(per plug - modeled onevent_on_startup
)Note I had to test that
tplinksmartplug
itself had finished startup or else it would try to connect at Octoprint startup (if Octoprint had autostartup enabled). This would then conflict with tplinksmartplug's own separate feature to connect automatically on Octoprint startup.So as it works now, the feature only works after the initial Octoprint startup.
Note this also overlaps with the feature that automatically turns on when a file is uploaded for printing in that generates a
connect
hook call but I don't see any harm there -- though presumably one could test to avoid this.