Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd Tab Behavior with TouchUI #164

Open
darkgrue opened this issue Sep 10, 2021 · 11 comments
Open

Odd Tab Behavior with TouchUI #164

darkgrue opened this issue Sep 10, 2021 · 11 comments
Labels
bug Something isn't working plugin conflict issue related to another plugin
Milestone

Comments

@darkgrue
Copy link

I've recently added a Sonoff S31 that I've flashed with Tasmota and installed the Tasmota plug-in for OctoPrint, but I'm seeing some really odd UI behavior in TouchUI that I'm not sure why it's happening. Three tabs get added to the hamburger menu, two titled "Tasmota" (the first shows the power/cost/etc. graph, the second is a blank page), the third tab is just the icon switch toggle (and doesn't switch pages, it functions exactly like the status bar icon in the full UI).

Screenshot 2021-09-10 113647

I suspect it gets worse when you have more than one Tasmota device set up, I only have the one right now. But the blank tab is definitely odd. I assume part of it is how TouchUI fiddles things, but is there an issue on the plug-in side as well?

@jneilliii
Copy link
Owner

I assume you cross-posted an issue to TouchUI repo as well? The one that shows the graph is moved into there from a tab, the other one is probably the sidebar where you can toggle the idle timeout value, and then obviously the one with the correct icon is the navbar button.

@darkgrue
Copy link
Author

I assume you cross-posted an issue to TouchUI repo as well? The one that shows the graph is moved into there from a tab, the other one is probably the sidebar where you can toggle the idle timeout value, and then obviously the one with the correct icon is the navbar button.

I hadn't, because I wasn't sure what was actually happening. It sounds like this is a side-effect of what TouchUI does, and maybe a feature request is needed to be able to suppress certain behavior, either by configuration of TouchUI, or plug-ins can programmatically give hints to tell TouchUI to handle things differently...

I'll post it to TouchUI as well, and cross-ref them. Thanks!

@darkgrue
Copy link
Author

Opened BillyBlaze/OctoPrint-TouchUI#512 as well.

@jneilliii
Copy link
Owner

Thanks. I had requested this type of touchui plugin handling config before but it never got anywhere and Billy just kept patching for conflicts by not loading or blocking certain plugins. I've programmed workarounds for touchui before, but not sure if this is a case in which I could do that, specifically for the sidebar header toggle switch.

@darkgrue
Copy link
Author

No worries, just wasn't sure which end of the problem to work first! Working both makes more sense, of course... =)

@jneilliii jneilliii added bug Something isn't working plugin conflict issue related to another plugin labels Sep 11, 2021
@darkgrue
Copy link
Author

darkgrue commented Oct 3, 2021

Well, the TouchUI issue was closed without any action or comment, so I guess nothing has changed there.

@jneilliii
Copy link
Owner

Just received a PR from @steve-grb that should fix this in #170 I have merged to the RC branch and will release an rc version shortly for testing. You can change the plugin's release channel in OctoPrint's Software Update settings to Release Candidate and upgrade when prompted to get the changes and confirm everything is working as expected.

@jneilliii
Copy link
Owner

Actually, I take that back. Steve's fix was not for the additional items showing, but the actual icon not being clickable in TouchUI.

@jneilliii
Copy link
Owner

I do believe this is something I can fix with some css tricks, just have to experiment with it.

@jneilliii jneilliii added this to the 1.1.1 milestone Jan 14, 2022
@jneilliii
Copy link
Owner

@darkgrue the one that doesn't show anything is the Tasmota tab. It has a plotly.js graph on it with graphed sensor data. If it's completely blank then your device or browser probably doesn't support webgl. Can you provide more details as to what browser/device you are using?

@darkgrue
Copy link
Author

@darkgrue the one that doesn't show anything is the Tasmota tab. It has a plotly.js graph on it with graphed sensor data. If it's completely blank then your device or browser probably doesn't support webgl. Can you provide more details as to what browser/device you are using?

At the time, I was using Chrome on Windows 10.

@jneilliii jneilliii modified the milestones: 1.1.1, 1.1.3 Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugin conflict issue related to another plugin
Projects
None yet
Development

No branches or pull requests

2 participants