add compiled lib to package #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaoventura
reviewed
Sep 21, 2018
setup.py
Outdated
| packages=find_packages() | ||
| packages=find_packages(), | ||
| package_data={'pylibui.libui.sharedlibs': '*'}, | ||
| include_pacakge_data=True, |
There was a problem hiding this comment.
Isn't "pacakge" mispelled? It may be this that is failing the CI build..
There was a problem hiding this comment.
Yes, I misspelled it. (I make an amend commit) But I check the log. It's because the test need to mkdir pylibui/libui/sharedlibs where I have to put an __init__.py. I've add an if for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One shall expect the compiled libraries to be placed in installed path (one could also put soft links if he/she needs to 'share' it) , since otherwise python will complain about the missing dynamic lib.