Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect changes made on Garmin Connect? #48

Open
Gandalf-the-Blue opened this issue Nov 22, 2024 · 4 comments
Open

Reflect changes made on Garmin Connect? #48

Gandalf-the-Blue opened this issue Nov 22, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@Gandalf-the-Blue
Copy link

So I had an activity of 52m 31s today which was automatically pulled from my Garmin Connect to Endurain (love this, btw!) but then I came back home and made some changes to the activity such that the new time is 52m 29s on Garmin Connect.
I tried pulling in data on Endurain manually, but it does not reflect the new reduced time. I know it's a bit nitpicky in this situation, but I wonder if this is the case for other aspects of the activity too, later on.

@joaovitoriasilva
Copy link
Owner

Currently the process works by downloading the .fit file from Garmin and uploading. Can you verify before and after changing, uploading the .fit file manually to Endurain if it shows the differences?

I am not sure if python-garminconnect has a function to retrieve a specific activity in JSON or similar so it can be imported. I will check it.

@Gandalf-the-Blue
Copy link
Author

Gandalf-the-Blue commented Nov 22, 2024

Okay, so I checked the last modified time for the .fit file in my local file storage, and it seems to be earlier than when I made the changes on Garmin Connect. I'm guessing that when you retrieve the files from Garmin, you do some sort of check to not import duplicates?
I am also wondering if in that API you get a last modified time from Garmin, if so, adding a filter to compare if the file has changed since you last downloaded it, should resolve the issue. And so if there's a newer version of the file, discard the previous one, and process the new one?

@joaovitoriasilva
Copy link
Owner

I do a check by Garmin activity ID. If an activity with that Garmin activity ID already exists, it skips the processing of it.

I need to check what methods are available in the library. But currently I don't check it, so it is normal what is happening to you. This is also true for Strava.

@Gandalf-the-Blue
Copy link
Author

Ah, yes. I checked the code just now. I'm hoping that the activity object also has a last modified time for each activity, doing a check on that should solve the issue. Thanks for all your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

2 participants