Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locations #18

Closed
joatu opened this issue Oct 1, 2014 · 8 comments
Closed

Locations #18

joatu opened this issue Oct 1, 2014 · 8 comments

Comments

@joatu
Copy link

joatu commented Oct 1, 2014

  • Allow users to submit & have their locations saved whether or not there is a community within their vicinity.
@undergroundwebdesigns
Copy link
Contributor

We actually already do this, but I agree the interface is not clear at all. Right now, if there are one or more communities near the address you entered, a select box shows up and you get to pick which one you wish to be "primarily" associated with. If there are no communities, it says so, but still grabs the location data to save to your profile when you save the form or hit register.

Like I said, not great. How do you think it should work?

@joatu
Copy link
Author

joatu commented Oct 1, 2014

It wasn't saving my location in my profile when there wasn't a community nearby. Perhaps this isn't an enhancement then, just a bug?

As far as the rest of what you said, I think it's fine for the time being. I can't think of a better way right now.

@undergroundwebdesigns
Copy link
Contributor

Might be just a bug then. Bear in mind, I never coded anything to display this information anywhere. It gets stored and that's it (for now). Your account does have location data (I just checked) and I did a quick look earlier and saw there were a few other accounts besides ours that have location data, so it seems to be working to me.

@joatu
Copy link
Author

joatu commented Oct 1, 2014

Everyone should have their location data stored if they've created a user account then. If any accounts are missing that data, is that to say they bypassed submitting it in the registration?

@undergroundwebdesigns
Copy link
Contributor

I don't think there's anything in the code that requires someone to enter a location, so I think you can just ignore the field altogether (right now). Requiring location info (whether or not there is a community) is something we can do though.

@joatu
Copy link
Author

joatu commented Oct 1, 2014

Yes, let's make it a requirement for registration please.

On Wed, Oct 1, 2014 at 10:57 AM, Alex Willemsma [email protected]
wrote:

I don't think there's anything in the code that requires someone to
enter a location, so I think you can just ignore the field altogether
(right now). Requiring location info (whether or not there is a community)
is something we can do though.

Reply to this email directly or view it on GitHub
#18 (comment).

@undergroundwebdesigns
Copy link
Contributor

As per discussion, the task here is simply to make sure that each registering user enters some address information, lets say to at least the city level. The existing code uses the Google API's to populate a number of hidden input fields, so ensuring that that code populates the city field and erroring if not should cover this.

@undergroundwebdesigns
Copy link
Contributor

Closing this as it's proposals are covered more succinctly in issue #40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants