Improving test coverage

.scrutinizer.yml

@@ -19,7 +19,7 @@ checks:
 tools:
     external_code_coverage:
         timeout: 600
-        runs: 3
+        runs: 2
     php_analyzer: true
     php_code_coverage: false
     php_code_sniffer:

.travis.yml

@@ -1,7 +1,6 @@
 language: php
 
 php:
-  - 5.4
   - 5.5
   - 5.6
   - 7.0

composer.json

@@ -23,8 +23,8 @@
         }
     ],
     "require": {
-        "php": ">=5.4.0",
-        "jobbrander/jobs-common": "~0.3"
+        "php": ">=5.5.0",
+        "jobbrander/jobs-common": "~0.7"
     },
     "require-dev": {
         "phpunit/phpunit": "3.7.*",

src/Careerbuilder.php

@@ -55,7 +55,7 @@ public function createJobObject($payload)
             'Location',
             'City',
             'State',
-            'PostedTime',
+            'PostedDate',
             'Pay',
             'JobTitle',
             'CompanyImageURL',
@@ -83,7 +83,7 @@ public function createJobObject($payload)
         )->setCompanyUrl($payload['CompanyDetailsURL'])
             ->setCity($payload['City'])
             ->setState($payload['State'])
-            ->setDatePostedAsString($payload['PostedTime'])
+            ->setDatePostedAsString($payload['PostedDate'])
             ->setCompanyLogo($payload['CompanyImageURL']);
 
         if (isset($payload['Skills']['Skill'])) {

tests/src/CareerbuilderTest.php

@@ -5,6 +5,10 @@
 
 class CareerbuilderTest extends \PHPUnit_Framework_TestCase
 {
+    private $clientClass = 'JobBrander\Jobs\Client\Providers\AbstractProvider';
+    private $collectionClass = 'JobBrander\Jobs\Client\Collection';
+    private $jobClass = 'JobBrander\Jobs\Client\Job';
+
     public function setUp()
     {
         $this->client = new Careerbuilder();
@@ -162,6 +166,46 @@ public function testItCanCreateJobFromPayload()
         $this->assertEquals($payload['JobDetailsURL'], $results->url);
     }
 
+    public function testItCanConnect()
+    {
+        $provider = $this->getProviderAttributes(['format' => 'xml']);
+        $payload = [];
+
+        $responseBody = "<?xml version=\"1.0\" encoding=\"UTF-8\" ?><ResponseJobSearch><Results>";
+
+        for ($i = 0; $i < $provider['jobs_count']; $i++) {
+            $jobArray = $this->createJobArray();
+            $path = $provider['path'];
+            array_push($payload, $jobArray);
+            $responseBody .= "<JobSearchResult><JobTitle>".$jobArray['JobTitle']."</JobTitle>";
+            $responseBody .= "<PostedDate>".$jobArray['PostedDate']."</PostedDate>";
+            $responseBody .= "</JobSearchResult>";
+        }
+
+        $responseBody .= "</Results></ResponseJobSearch>";
+
+        $job = m::mock($this->jobClass);
+        $job->shouldReceive('setQuery')->with($provider['keyword'])
+            ->times($provider['jobs_count'])->andReturnSelf();
+        $job->shouldReceive('setSource')->with($provider['source'])
+            ->times($provider['jobs_count'])->andReturnSelf();
+
+        $response = m::mock('GuzzleHttp\Message\Response');
+        $response->shouldReceive('getBody')->once()->andReturn($responseBody);
+
+        $http = m::mock('GuzzleHttp\Client');
+        $http->shouldReceive(strtolower($this->client->getVerb()))
+            ->with($this->client->getUrl(), $this->client->getHttpClientOptions())
+            ->once()
+            ->andReturn($response);
+        $this->client->setClient($http);
+
+        $results = $this->client->getJobs();
+
+        $this->assertInstanceOf($this->collectionClass, $results);
+        $this->assertCount($provider['jobs_count'], $results);
+    }
+
     private function createJobArray() {
         return [
             'Company' => uniqid(),
@@ -176,7 +220,7 @@ private function createJobArray() {
             'Location' => uniqid(),
             'City' => uniqid(),
             'State' => uniqid(),
-            'PostedTime' => date('F j, Y, g:i a'),
+            'PostedDate' => date('m/d/Y'),
             'Pay' => uniqid(),
             'JobTitle' => uniqid(),
             'CompanyImageURL' => uniqid(),
@@ -190,4 +234,18 @@ private function createJobArray() {
             ]
         ];
     }
+
+    private function getProviderAttributes($attributes = [])
+    {
+        $defaults = [
+            'path' => uniqid(),
+            'format' => 'json',
+            'keyword' => uniqid(),
+            'source' => uniqid(),
+            'params' => [uniqid()],
+            'jobs_count' => rand(2,10),
+
+        ];
+        return array_replace($defaults, $attributes);
+    }
 }