Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Unit Tests #9

Open
joesaunderson opened this issue Oct 1, 2019 · 4 comments · May be fixed by #10
Open

Add Unit Tests #9

joesaunderson opened this issue Oct 1, 2019 · 4 comments · May be fixed by #10
Labels
hacktoberfest

Comments

@joesaunderson
Copy link
Owner

joesaunderson commented Oct 1, 2019 •
edited
Loading

Add Unit tests for each endpoint with mocked API responses.

See: sportmonks.com
@davidribeiro
Copy link

@joesaunderson I can help with tests for some of the endpoints if you want to

@joesaunderson
Copy link
Owner Author

joesaunderson commented Oct 2, 2019 •
edited
Loading

@davidribeiro great thanks! Maybe start with 5 tests per PR?

I think it would be good to mock the responses from the API

@davidribeiro
Copy link

davidribeiro commented Oct 2, 2019 •
edited
Loading

Sure, no problem

@davidribeiro davidribeiro linked a pull request Oct 2, 2019 that will close this issue
Open
@davidribeiro
Copy link

@joesaunderson take a look and see what do you think : #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unit tests and a base for easier testing endpoints
2 participants
@joesaunderson @davidribeiro