Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Symfony ExecutableFinder for locating vagrant binary #2

Open
c33s opened this issue Jul 13, 2016 · 1 comment
Open

Use Symfony ExecutableFinder for locating vagrant binary #2

c33s opened this issue Jul 13, 2016 · 1 comment

Comments

@c33s
Copy link

c33s commented Jul 13, 2016

in your Base.php file, you use a hardcoded path, which is also linux specific. on windows your task would fail, except i provide the path to the executable.

i would reccomend using the symfony ExecutableFinder of the symfony/process component, which avoids hardcoded path and also is cross platform compatible.

an example usage is the PhpExecutableFinder which is performance optimized. the real ExecutableFinder is called at Line 70

@joestewart
Copy link
Owner

Thanks!

It appears that Robo 1.x will have this supported with a findExecutable method using ExecutableFinder.

https://github.com/consolidation-org/Robo/blob/master/src/Common/ExecCommand.php

Added a PR on #3 for some additional testing.

On linux and OS X I think it could pretty much be assumed that vagrant is in the PATH though and just call "vagrant"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants