[Feature] Import GitHub Labels as tags #2866
Comments
|
Thank you very much for opening up this issue! I am currently a bit overwhelmed by the many requests that arrive each week, so please forgive me, if I fail to respond personally. I am still very likely to at least skim read your request and I'll probably try to fix all (real) bugs if possible and I will likely review every single PR being made (please, give me a heads up if you intent to do so) and I will try to work on popular requests (please upvote via thumbs up on the original issue) whenever possible, but trying to respond to every single issue over the last years has been kind of draining and I need to adjust my approach for this project to remain fun for me and to make any progress with actually coding new stuff. Thanks for your understanding! |
|
Hello there MiragonMx! 👋 Thank you and congratulations 🎉 for opening your very first issue in this project! 💖 In case you want to claim this issue, please comment down below! We will try to get back to you as soon as we can. 👀 For more open ended discussions and/or specific questions, please visit the discussions page. 💖 |
|
This issue has not received any updates in 90 days. Please comment, if this still relevant! |
|
afaik not addressed yet |
|
This issue has not received any updates in 90 days. Please comment, if this still relevant! |
Bump against stale tag |
|
I am all for adding this s an optional feature. PRs are welcome! |
|
I started fiddling around with this, will open a PR soon, if thats fine with you, you can assign me to the issue :) |
That's great to hear! Please let me know if you have any questions! The feature should be opt-in I think. |
|
I'm positive that I've got the logic needed, will look into the menu options (I agree, should definitely be opt-in), but it's currently untested, I'll try to get it up and running locally but that might take some days (I'll probably have some capacity on sunday)... On a different note: I stumbled over a minor typo in an enum string (3af6e2f), should that get it's own PR? Regarding the issue related PR, I'll fix up a branch with sensible commits (and msgs) first and then open it ASAP so you can have a look whenever it works, current state is just WIP from on the go so it doesn't really come together nicely yet :D |
|
So I ran into a problem: Its still not in a PR-able state, but if anyone wants to poke around in my current state, its here: https://github.com/MiragonMx/super-productivity/tree/dev |
That would be ideal! Thank you! I try to have a look at the other changes this Friday. I hope I find the time :) |
Change the enum value of AddNewTagsFromShortSyntax to correctly reflect
element ('from' instead of 'form')
No issue existing for this, discussed in johannesjo#2866
|
- adjust GithubIssue models to include a label array - moves the label element from GithubIssue to GithubIssueReduced (indirectly in GithubIssue still through extension) (`github-issue.model.ts`) - get them from the graphQL API (`gihub-issue-map.util.ts`) - add labels with a private helper function as tags (with import of name and color) using TagService utilities (`gihub-common-interfaces.service.ts`) part of the implementation regarding johannesjo#2866
- add config member for a flag to import labels as tags or not (`github.model.ts`) - set default for that config member to false and add to UI form (`github.const.ts`) - add const elements for that form to be filled in with translation elements/values (`t.const.ts`) - first formulations of form elements in english and german (`en.json`, `de.json`) part of the implementation regarding johannesjo#2866
I cleaned up what I have so far into two hopefully logical commits and a clean-ish PR #3348 As I said, I'll probably have some time on Sunday to fiddle a bit, but I'm more than happy to get pointers/ideas/comments - first angular-project, 'real' PR and so on.. :) |
Change the enum value of AddNewTagsFromShortSyntax to correctly reflect
element ('from' instead of 'form')
No issue existing for this, discussed in #2866
|
Thank you very much! I'll have a look tomorrow :) looks good so far. |
First of all, thanks for the great app, I've been using it for some time for time management at work and it's been great! GitHub integration for a personal project also already works really well, but this request is something that would make it even better!
Problem Statement
With imported GitHub issues, I get all the interesting info related to the Issues themselves. However, I lose the abitlity to sort them by label inside Super Productivity.
❔ Possible Solution
It would be great for me if you could (as another checkable setting) set the GitHub labels as tags for the individual tasks to sort by these afterwards in Super Productivity as well. They are obviously queried in the api, as they are shown in the additional infos, so I imagine it wouldn't be that big of a change to also add those as tags.
Alternatively, I could go back to GitHub for sorting and thus sort my issues by hand or add the labels manually by editing each task. This is not a massive problem, it's more of a convenience request and the question, if this functionality already exists and I just haven't found it...
➕ Additional context
I'm not aware of issues or PR's relating to this problem. I suppose some work would have to be done in src/app/features/tasks/ and src/app/features/issue/providers/github/ (here, the labels are queried as issue?.labels (in template html github-issue/github-issue-content component), but I'm not sure, how one could go about handing this data 'up' to the task level where the tags are handled. Sadly I don't really have any significant TypeScript experience and none at all regarding Angular, thus I don't feel confident that I could further pin down this problem or a solution in this rather impressive but thus also quite large project.
I'd be happy to hear about your insight, whether this is feasible and how much work this would create!
The text was updated successfully, but these errors were encountered: