Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Delete function is not observed and no revision is saved on ->delete #10

Open
nekromoff opened this issue Jan 3, 2018 · 2 comments

Comments

@nekromoff
Copy link

No revision is created when using delete:

Item::where('user_id', $user->id)->delete();

Destroy works properly and revision is created:

$item=Item::where('user_id', $user->id)->first();
Item::destroy($item->id);
@nekromoff nekromoff changed the title Bug: Delete function is not observed and no revision is saved on delete Bug: Delete function is not observed and no revision is saved on ->delete Jan 3, 2018
@johannesschobel
Copy link
Owner

Hey man, thanks for your feedback on this one.

You have the chance to submit a PR to add this feature?
Thanks in advance and cheers

@nekromoff
Copy link
Author

I'll check it, but in the meantime I have resolved this using workaround that directly uses Revision model (table).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants