Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoke sometimes intersects the flame #19

Open
ndetommaso opened this issue Dec 22, 2015 · 1 comment
Open

Smoke sometimes intersects the flame #19

ndetommaso opened this issue Dec 22, 2015 · 1 comment
Labels

Comments

@ndetommaso
Copy link

When the smoke is on, sometimes the particles will be layered on top of the flame. This would be fine, except that the smoke maintains the dark background, effectively cutting a hole into the flame.

@johanvts
Copy link
Owner

I have been thinking about how to fix this and most of my ideas would require a rewrite to handle the drawing of smoke globally on a pr. fireplace basis rather than the current pr. flame method. However I think I have found a fix that would be much easier to implement: Sample and reuse the current face background when drawing the smoke. However this might effect performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants