Infinite recursion before init.

[chrono-meter]

After updating to WordPress 6.8-alpha-59341, I'm experiencing an infinite recursion when loading translation files.

Problem at:

query-monitor/classes/Util.php

Lines 245 to 246 in 6b66f65

	case 'core':
	$name = __( 'WordPress Core', 'query-monitor' );

The behavior of _load_textdomain_just_in_time has changed in WordPress 6.8.

Here is the monkey patch:

add_filter('lang_dir_for_domain', function ( $path, $domain ) {
	if ( 'query-monitor' === $domain && ( ! doing_action( 'after_setup_theme' ) && ! did_action( 'after_setup_theme' ) ) ) {
		$path = false;
	}

	return $path;
}, 10, 2 );

[johnbillion]

Thanks @chrono-meter . This is likely due to the additional safety checks added to translation file loading recently. I will take a look.

[johnbillion]

The underlying problem here is that if another plugin triggers a PHP error or tries to load a translation file too early, the data collection in Query Monitor can end up triggering further translation loading, which triggers further doing it wrongs. I need to look at a more fundamental change in QM so that translation strings are always deferred until the output.