Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check_version and _unused #58

Open
ksjogo opened this issue Dec 17, 2021 · 1 comment
Open

check_version and _unused #58

ksjogo opened this issue Dec 17, 2021 · 1 comment

Comments

@ksjogo
Copy link
Contributor

ksjogo commented Dec 17, 2021

Both files seem not used/their one calling site commented out. Should they be removed?
@johnfn
Copy link
Owner

johnfn commented Dec 17, 2021

Oh, it's actually very much intended for checkVersionAsync to be used! I must have unintentionally commented it out. The idea is just to show a warning if you're on an old version of ts2gd.

As for _unused, it is indeed... unused. :D It was to remind myself of some TS cases I should consider but it's not necessary any more. We can definitely get rid of that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johnfn @ksjogo