Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening a project modifies workbench.colorCustomizations even when "Surprise me on startup" is disabled #551

Open
ferm10n opened this issue Jul 2, 2024 · 1 comment

Comments

@ferm10n
Copy link

ferm10n commented Jul 2, 2024

Versions (please complete the following information):

  • OS: Windows 10
  • VS Code version: 1.89.1
  • Peacock Version: 4.2.2

Describe the bug
I previously used peacock to set a color theme for a project. I then disabled peacock because it kept making unwanted changes to .vscode/settings.json workbench.colorCustomizations. Now I try to enable it with the "surprise me on startup" set to false, and it tries to remove almost all the options in workbench.colorCustomizations.

To Reproduce
Steps to reproduce the behavior:

  • put this in .vscode/settings.json:
{
  "workbench.colorCustomizations": {
    "activityBar.activeBackground": "#425a70",
    "activityBar.activeBorder": "#281820",
    "activityBar.background": "#425a70",
    "activityBar.foreground": "#e7e7e7",
    "activityBar.inactiveForeground": "#e7e7e799",
    "activityBarBadge.background": "#281820",
    "activityBarBadge.foreground": "#e7e7e7",
    "commandCenter.border": "#e7e7e799",
    "sash.hoverBorder": "#425a70",
    "statusBar.background": "#2f4050",
    "statusBar.foreground": "#e7e7e7",
    "statusBarItem.hoverBackground": "#425a70",
    "statusBarItem.remoteBackground": "#2f4050",
    "statusBarItem.remoteForeground": "#e7e7e7",
    "tab.activeBorderTop": "#21b8bb",
    "titleBar.activeBackground": "#2f4050",
    "titleBar.activeForeground": "#e7e7e7",
    "titleBar.inactiveBackground": "#2f405099",
    "titleBar.inactiveForeground": "#e7e7e799"
  }
}
  • disable "surprise me on startup"
  • open the project with that vscode settings.json
  • peacock modifies it to be this:
{
  "workbench.colorCustomizations": {
    "activityBar.activeBorder": "#281820",
    "tab.activeBorderTop": "#21b8bb"
  }
}

Expected behavior
Color configuration should not be modified unless peacock command is invoked.

@willpower232
Copy link
Contributor

It might be worth looking at your main config json file in case there is another peacock setting present and it is getting confused

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants