New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in daysInMonth - wrong startdate when date is a sunday #8

Open

Paul-Todd opened this issue Oct 19, 2018 · 0 comments

Paul-Todd commented Oct 19, 2018

I noticed that when the first weekday is a sunday an extra week is added in front.

The fix is to do a modulus on the daysBefore so if it is a sunday the remainder is zero and zero is subtracted.

date_utils:32 firstToDisplay = first.subtract(new Duration(days: daysBefore % 7));

With this fix the days now align with Microsoft Outlook monthly calendar as well as Google calendar monthly calendar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment