JOINDIN-697: Time picker throws warnings for single-digit times in Chrome

[ghost]

Jira issue originally created by user liam-wiltshire:

When you try to create a talk using Chrome, the time-picker doens't update the input field if the hour is single digit (e.g. 9:00, 8:30 etc).

The console throws the following warning:

""The specified value "9:15" does not conform to the required format. The format is "HH:mm", "HH:mm:ss" or "HH:mm:ss.SSS" where HH is 00-23, mm is 00-59, ss is 00-59, and SSS is 000-999.""

If the hour is a double digit hour (10, 11 etc), it works fine.

Works even with a single digit hour in Firefox

[ghost]

Comment created by cal-tec:

This issue is actually with the bootstrap-timepicker.js component https://github.com/jdewit/bootstrap-timepicker

There appears to be a PR open for it but it has not been merged jdewit/bootstrap-timepicker#203. I hav hacked the code to implement the fix proposed by the open PR and it does fix the issue.

I see there are three options

1. Wait until the bootstrap-timepicker component is fixed.

2. Hack the component so that it works for joind.in (NOT REALLY A FAVOURABLE OPTION)

3. Remove the component

Any preferences or other thoughts on how to proceed?????

[ghost]

Comment created by liam-wiltshire:

Not sure on anyone else's preference, but I don't really want to remove the component, as apart from the bug it does work well.

As such, personally, I'd:

a) Fix the component for now
b) Raise a ticket in reference to the PR on the upstream project, to re-pull in that component once it's available.

That way, we get the best of both worlds :-)

[ghost]

Comment created by cal-tec:

Ok,

I have fixed the component and submitted a PR

Not sure quite what you mean regards to b)... Do you mean crate a new jira issue to re-pull the bootstrap-timepicker.js component once the PR on that component has been merged / the component has been fixed??

[ghost]

Comment created by liam-wiltshire:

Thanks, will merge that today.

Yes exactly, open a JIRA issue with a link know to the PR so we can look to update the component once the upstream is.

[ghost]

Comment created by +railto:

Never seen your comment Liam, have merged it already, I just can't close jira issues yet

[ghost]

Comment created by +railto:

Changes merged

[ghost]

Issue was closed with resolution "Fixed"