correctly extract the description for payment_options from the free-f…

…orm invoice endpoint description
jolicode · Aug 17, 2023 · 9515a1e · 9515a1e
1 parent 0f8c74b
commit 9515a1e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/generated/harvest-openapi.yaml b/generated/harvest-openapi.yaml
@@ -6446,7 +6446,7 @@ paths:
                   nullable: true
                 payment_options:
                   type: array
-                  description: "\_"
+                  description: 'The payment options available to pay the invoice. Your account must be configured with the appropriate options under Settings > Integrations > Online payment to assign them. Options: [ach, credit_card, paypal]'
                   nullable: true
                   items:
                     type: string

diff --git a/src/Extractor/Extractor.php b/src/Extractor/Extractor.php
@@ -519,8 +519,16 @@ public static function buildRequestBody($method, $path, $explicitParameters, $ex
                 $$columnName = array_shift($explicitParameters);
             }
 
-            if (isset($required) && 'required' === $required) {
-                $requiredProperties[] = $parameter;
+            if (isset($required)) {
+                if ('*optional' === $required) {
+                    $required = 'optional';
+                }
+
+                if ('required' === $required) {
+                    $requiredProperties[] = $parameter;
+                } else if (!\in_array($required, ['optional', 'required'])) {
+                    $description = $required;
+                }
             }
 
             $property = self::buildDefinitionProperty($parameter, $type, $description, $path, $method);