Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Give option to) stop strict checking for PLATFORM #343

Closed
Aephir opened this issue Dec 1, 2024 · 5 comments
Closed

(Give option to) stop strict checking for PLATFORM #343

Aephir opened this issue Dec 1, 2024 · 5 comments

Comments

@Aephir
Copy link

Aephir commented Dec 1, 2024

Is your feature request related to a problem? Please describe.
Since most of the total electricity cost is taxes and fees that change dynamically, I created a custom integration that gets the specific taxes and fees (that change based on a few factors) from a Danish electricity monitoring API, to make a sensor with the same general structure as the Nordpool sensor.

However, since the domain (I think this is where the problem is?) is not "nordpool", the ev_smart_charging integration doesn't quite work - the sensor.ev_smart_charging_status keeps having the state "Waiting for new prices" even when tomorrows prices are populated.

It would be great if the checks (in the price_adaptor.py) were only for e.g. attributes of relevant structure (checking the "today", "tomorrow", "raw_today", or "raw_tomorrow").

Describe the solution you'd like
Don't reject price sensors that have the relevant information, but are not in domain: "nordpool". Or, perhaps just have a checkbox during configuration to disable the most stringent checks.

Describe alternatives you've considered
Changing the domain of my integration to "nordpool" or "energidataservice", but this seems to result in some clashes (with the "real" nordpool integration, I suspect), and the integration no longer loads.

Additional context
Add any other context or screenshots about the feature request here.

@KrzysztofHajdamowicz
Copy link
Contributor

This is worth considering, until then check my changes for general overview what fixes are needed to include Your integration:
#322

@jonasbkarlsson
Copy link
Owner

@Aephir I have made a pre-release v2.0.2-dev1 that should work with your integration, assuming it has "current_price", "raw_today" and "raw_tomorrow" with the same format as the Nordpool integration. Can you test if it works?

@jonasbkarlsson
Copy link
Owner

jonasbkarlsson commented Jan 5, 2025

@Aephir I checked your integration and noted that you don't have the attribute "current_price", so it will not work.

I will remove the usage of "current_price". Some of the price integration that already are supported don't have it, so it will be easy to fix this for me. So no need to modify your integration, unless you want to.

@jonasbkarlsson
Copy link
Owner

Part of release v2.1.0.

The ha-electricity-price integration should work now, but I have not been able to test it.

@Aephir
Copy link
Author

Aephir commented Jan 24, 2025

Sorry for the slow response, but initial tests suggests that it works. Thanks a bunch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants