Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slant keyword messes up the colors. #61

Open
sunhs opened this issue Jan 16, 2020 · 0 comments
Open

slant keyword messes up the colors. #61

sunhs opened this issue Jan 16, 2020 · 0 comments

Comments

@sunhs
Copy link

sunhs commented Jan 16, 2020

Hey man, thanks for your great work.

I'm using GNU Emacs 27.0.50 (built from source) on Ubuntu 16.04.

For faces like font-lock-comment-face where :slant italic is set, the foreground and background colors are reversed. For example, if :foreground ,atom-one-dark-fg :background ,atom-one-dark-bg :slant italic is set, actually foreground will be atom-one-dark-bg and background will be atom-one-dark-fg.

From the doc, slant seems to trigger some terminal features.

I changed :slant italic to :slant ,(if (display-graphic-p) 'italic 'normal) and things work well in the terminal. Haven't tried it in GUI since I'm working via ssh.

Lack knowledge on this part and would be great if you could explain this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant