-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The buttons are behind the title bar #2598
Comments
@Toadfield does the SDL2 version work better? |
yes |
Are you running the SDL2 version using XWayland or as a native Wayland app? e.g.
The SDL1 version can only run via XWayland, as SDL1 has no wayland support at all. The SDL2 libs do have some wayland support, but there are still issues, which is why SDL2 normally still defaults to X11 even on Wayland. |
It can only run on wayland using sdl12-compat. The dosbox-x condition must be built with the dynamic SDL1 library (not statically linked). dosbox-x.SDL1.wayland.mp4It is only a matter of time before wayland becomes the default. If not in the upcoming edition then in the next one. Many of these bugs are a matter of the WM used. Not all are KDE and Gnome supporters. It is also worth testing on something else - a very popular Sway. |
@grapeli I don't think your statements are completely correct. For instance the sdlmain your linking to is part of the modified SDL1 fork that is included with DOSBox-X. To my understanding it is not used when you build for SDL2. Here is dosbox-x SDL2 running in wayland mode on Gnome 40.2 As you can see all window decorations are missing, as SDL2 has not yet implemented CSD (Client-Side Decorations), and Gnome has not implemented (and has no intention of implementing) the optional SSD (Server-Side Decorations) extension. Once the libdecoration patch is merged in SDL2 and a new version is released of SDL2, SDL2 applications on Gnome will have window decorations again. In KDE you do get decorations in Wayland mode, since KDE supports the optional SSD extension. |
@rderooy There is no problem with window decorations under Sway (as far as I know under KDE). I have been using the X11 application for a long time. They never had decorations. This has always been the responsibility of the window manager (WM). Run any X11 application on xorg without WM. There will be no decorations either. |
@grapeli I have been working with Unix and Linux systems longer than most. I have used Motif for instance, and built my own Linux 0.9 kernels. I know that on X11 the window manager is responsible for the window decorations and if you don't have a window manager you don't have decorations. But that was not the point. My point was that on Wayland it no longer works the same way, and unless your chosen Wayland compositor implements the optional Wayland SSD extension, you will not have any window decorations, as is the case for Gnome and Enlightenment. In that case the SDL2 library would have to provide decorations, for which there is an open PR: libsdl-org/SDL#4068 |
@rderooy For many years I have been a user of notion (ion3) and i3 for some time also Sway. Their window decorations are devoid of the minimize and close function. Somehow I do not miss it. |
@rderooy dosbox-x.i3.mp4 |
I tested it,those bugs also happen on xorg session. |
@Toadfield Out of curiosity, I ran dosbox-x under KDE in archlinux. kde.archlinux.dosbox-x.sdl2.mp4edit: |
I know reinstalled arch cause I broke it and when I start dosbox-x now,then I don't see it at all,the window just doesn't show up even though I can see that it is opened in the task bar. |
Describe the bug
Look precisely under the titlebar,the buttons that I need to configure dosbox-x are behind the titlebar:
To Reproduce
Steps to reproduce the behavior:
Start dosbox-x
Environment (please complete the following information):
Arch kde wayland.
Newest dosbox-x.
The text was updated successfully, but these errors were encountered: