Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code page handling needs faster lookup table for converting Unicode *back* to the code page #5374

Open
2 tasks done
joncampbell123 opened this issue Jan 5, 2025 · 1 comment

Comments

@joncampbell123
Copy link
Owner

Is your feature request related to a problem? Please describe.

Current code is fast when converting a code page to Unicode.

However converting back to Unicode is currently done by a slow for() loop that searches the table.

What you want

The code page generation code needs to make a reverse lookup table to speed this up.

If the new UI toolkit is to allow Unicode so that language files could be used in the future, it should accept UTF-8 strings and needs this table to prevent bitmap text drawing performance issues (FreeType Unicode glyph lookup doesn't need this, when we get around to TrueType font support).

For example, Unicode to CP437 for the initial stock VGA font object in the GUI toolkit.

Describe alternatives you've considered

No response

Additional information

No response

Have you checked that no similar feature request(s) exist?

  • I have searched and didn't find any similar feature request.

Code of Conduct & Contributing Guidelines

  • I agree to follow the code of conduct and the contributing guidelines.
@Torinde
Copy link
Contributor

Torinde commented Jan 5, 2025

I think such conversion function exists in Staging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants