Update rand to 0.8 but use the SmallRng from 0.7 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonhoo
reviewed
Oct 3, 2021
| @@ -32,6 +32,11 @@ use std::{sync::Arc, time::Duration}; | |||
| use rand::prelude::*; | |||
| use tracing::{debug, info, info_span}; | |||
|
|
|||
| #[cfg(all(not(target_os = "emscripten"), target_pointer_width = "64"))] | |||
| type SmallRng = rand_pcg::Pcg64Mcg; | |||
| #[cfg(not(all(not(target_os = "emscripten"), target_pointer_width = "64")))] | |||
There was a problem hiding this comment.
I'm not sure I follow why the #[cfg] is needed here — why not use the same one on all targets?
There was a problem hiding this comment.
I just copied the code from rand 0.7
There was a problem hiding this comment.
Ah, I see! I think I'd prefer to go the u64 path and stick with rand's SmallRng. Given that we'll probably end up with a breaking change from #7, I'm okay with breaking on this now.
|
I've released bustle 0.5 with rand 0.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SmallRngof rand changed from 0.7 to 0.8 on 64 bit machines. The new PRNG has a different seed size. This PR updates rand but keeps the old PNRG as the least invasive change.Alternative:
Seed with an
u64as this is possible for all RNGs.