Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs mobile background #183

Open
bembelimen opened this issue Jul 31, 2021 · 5 comments
Open

Tabs mobile background #183

bembelimen opened this issue Jul 31, 2021 · 5 comments

Comments

@bembelimen
Copy link
Contributor

https://github.com/joomla-projects/custom-elements/blob/master/src/scss/tab/tab.scss#L53

Being in mobile view activating a tab the background becomes semi-transparent:

grafik

Without active everything is ok:

grafik

CC @dgrammatiko

@dgrammatiko
Copy link
Collaborator

I think it's coming from

background-color: transparent;

@helper-uttam
Copy link

Hey @bembelimen !
Can I work on this issue?

@bembelimen
Copy link
Contributor Author

Sure

@helper-uttam
Copy link

Hey @bembelimen ! Can I work on this issue?

Can you provide me some resource to setup this project into my machine for testing purposes. I have gone through the docs but still not able to set it up.

What I have done-

npm install joomla-ui-custom-elements
npm install -g grunt-cli
npm install grunt
After these installation I am tring to use Joomla custom elements by linking <link href="joomla-alert.min.css" rel="stylesheet"> and <script src="joomla-alert.min.js"></script> to my html file.

@dgrammatiko
Copy link
Collaborator

Can you provide me some resource to setup this project into my machine for testing purposes.

  • clone the repo git clone [email protected]:joomla-projects/custom-elements.git
  • Install npm dependencies npm install
  • Run npm run build to compile js and CSS

Probably you need a server to check the changes, you can have one with this command npx http-server

Before making a PR please lint your code and make sure that tests are still green. All the available command are here:

"scripts": {
"build": "rimraf dist && node ./node_modules/rollup/dist/bin/rollup -c rollup.config.js",
"lint:js": "node ./node_modules/eslint/bin/eslint.js src",
"lint:css": "stylelint --config .stylelintrc.json -s scss \"src/scss/**/*.scss\"",
"test": "node node_modules/karma/bin/karma start --single-run --browsers ChromeHeadless karma.conf.js",
"lint": "npm run lint:css && npm run lint:js",
"ci-test": "node node_modules/karma/bin/karma start karma-ci.conf.js --single-run"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants