Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make restore.php PHP 7.4 compatible #25800

Closed
HLeithner opened this issue Aug 9, 2019 · 3 comments
Closed

Make restore.php PHP 7.4 compatible #25800

HLeithner opened this issue Aug 9, 2019 · 3 comments
Labels
No Code Attached Yet

Comments

@HLeithner
Copy link
Member

HLeithner commented Aug 9, 2019 •
edited
Loading

Upgrading to @nikosdion current version of restore.php makes more trouble then fixing our version to support php 7.4.

See #25793

We need a PR to change indexed string accesses from {} to [] syntax
@ghost ghost added the J3 Issue label Aug 9, 2019
@richard67
Copy link
Member

There is PR #25782 . As far as I can see, @SharkyKZ had included restore.php and later reverted that due to upgrading. So if he again reverts the last commit, which is the revert commit, it should come back and all is fine. Or am I wrong?

@HLeithner
Copy link
Member Author

Yes but should an own PR for better testing, because breaking the upgrade system could be a real pain. So if @SharkyKZ can create a new pr (and change the copyright information requested by nik) it would be great.

@alikon alikon mentioned this issue Aug 9, 2019
Merged
@ghost
Copy link

ghost commented Aug 9, 2019

Closed as having Pull Request #25801

@ghost ghost closed this as completed Aug 9, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
No Code Attached Yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@HLeithner @richard67 @joomla-cms-bot