-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media Manager Folder Selectory a11y #38126
Media Manager Folder Selectory a11y #38126
Conversation
keyboard navigation works as expected for a tree |
d1c2f49
to
57cc5fd
Compare
Amazing. Thankyou! In that case code style issues fixed, branch rebased and this is ready for testing |
57cc5fd
to
d5bcb96
Compare
I have tested this item ✅ successfully on d5bcb96 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38126. |
@Quy presumably this is specifically for directories that don't have a child? |
Yes, that appears to be the case. |
d5bcb96
to
d4d3fdc
Compare
OK Should be fixed. Just added a extra if statement |
I have tested this item ✅ successfully on d4d3fdc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38126. |
1 similar comment
I have tested this item ✅ successfully on d4d3fdc This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38126. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38126. |
thanks |
Pull Request for Issue joomla/accessibility#58 .
Also raised directly by a blind user of Joomla as part of the Joomla User Group in London where he was unable to utilise the media manager without a mouse because of this specific issue.
Summary of Changes
Adds keyboard support for navigating the media manager directory view trying to follow the examples at https://w3c.github.io/aria-practices/examples/treeview/treeview-1/treeview-1b.html
//cc @brianteeman because I suspect you have a much better idea of best practice than me. Also @chmst from the a11y team
For Maintainers
Practically this merges the item and tree view's together because without it you have to start doing weird event emissions as events in vue only bubble to the parent component and not higher. This is fine for us - but it practically only works if you have the entire tree in a single view. I've done the merge (without changes) in one commit. Then applied the a11y fixes in the second commit for easier review.
Testing Instructions
Check that the media manager folder tree still renders in the browser
Actual result BEFORE applying this Pull Request
Tree renders. Before patch there is no way beyond selecting the area to navigate between items.
Expected result AFTER applying this Pull Request
Tree renders. You can move through items in tree once selected with the up/down arrows (for items in the same level of nesting) and use the left/right arrow keys to move between layers. Enter to select one.
Documentation Changes Required
None