Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Media Manager Folder Selectory a11y #38126

Merged
merged 2 commits into from
Jun 27, 2022

Conversation

wilsonge
Copy link
Contributor

@wilsonge wilsonge commented Jun 22, 2022

Pull Request for Issue joomla/accessibility#58 .

Also raised directly by a blind user of Joomla as part of the Joomla User Group in London where he was unable to utilise the media manager without a mouse because of this specific issue.

Summary of Changes

Adds keyboard support for navigating the media manager directory view trying to follow the examples at https://w3c.github.io/aria-practices/examples/treeview/treeview-1/treeview-1b.html

//cc @brianteeman because I suspect you have a much better idea of best practice than me. Also @chmst from the a11y team

For Maintainers

Practically this merges the item and tree view's together because without it you have to start doing weird event emissions as events in vue only bubble to the parent component and not higher. This is fine for us - but it practically only works if you have the entire tree in a single view. I've done the merge (without changes) in one commit. Then applied the a11y fixes in the second commit for easier review.

Testing Instructions

Check that the media manager folder tree still renders in the browser

Actual result BEFORE applying this Pull Request

Tree renders. Before patch there is no way beyond selecting the area to navigate between items.

Expected result AFTER applying this Pull Request

Tree renders. You can move through items in tree once selected with the up/down arrows (for items in the same level of nesting) and use the left/right arrow keys to move between layers. Enter to select one.

Documentation Changes Required

None

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.2-dev labels Jun 22, 2022
@wilsonge wilsonge changed the title Feature/keyboard media menu Media Manager Folder Selectory a11y Jun 22, 2022
@Quy Quy mentioned this pull request Jun 22, 2022
6 tasks
@brianteeman
Copy link
Contributor

keyboard navigation works as expected for a tree

@wilsonge wilsonge force-pushed the feature/keyboard-media-menu branch 4 times, most recently from d1c2f49 to 57cc5fd Compare June 22, 2022 19:43
@wilsonge
Copy link
Contributor Author

wilsonge commented Jun 22, 2022

keyboard navigation works as expected for a tree

Amazing. Thankyou!

In that case code style issues fixed, branch rebased and this is ready for testing

@wilsonge wilsonge force-pushed the feature/keyboard-media-menu branch from 57cc5fd to d5bcb96 Compare June 22, 2022 19:47
@wilsonge wilsonge added the a11y Accessibility label Jun 22, 2022
@chmst
Copy link
Contributor

chmst commented Jun 23, 2022

I have tested this item ✅ successfully on d5bcb96

I am pleased to press the successful here for Julian with his comment: "Regarding the modification by George on the media manager, it’s wonderful! Previously it was very difficult to choose an image folder but now, it works very well with a screen reader. Very impressed and thank you George."


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38126.

@Quy
Copy link
Contributor

Quy commented Jun 23, 2022

Select a directory.
Press the right arrow key.

38126

@wilsonge
Copy link
Contributor Author

@Quy presumably this is specifically for directories that don't have a child?

@Quy
Copy link
Contributor

Quy commented Jun 23, 2022

Yes, that appears to be the case.

@wilsonge wilsonge force-pushed the feature/keyboard-media-menu branch from d5bcb96 to d4d3fdc Compare June 23, 2022 21:34
@wilsonge
Copy link
Contributor Author

OK Should be fixed. Just added a extra if statement

@richard67
Copy link
Member

@chmst Do you think you can contact Julian and motivate him to do again a test? There has been made a fix for trying to navigate to a subfolder with the right arrow key when there is no subfolder. And could you ask him to test the other PR #38141 , too? That would be really cool. Thanks in advance.

@richard67
Copy link
Member

I have tested this item ✅ successfully on d4d3fdc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38126.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Jun 27, 2022

I have tested this item ✅ successfully on d4d3fdc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38126.

@Quy
Copy link
Contributor

Quy commented Jun 27, 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38126.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 27, 2022
@HLeithner HLeithner merged commit 8b2cf5a into joomla:4.2-dev Jun 27, 2022
@HLeithner
Copy link
Member

thanks

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 27, 2022
@wilsonge wilsonge deleted the feature/keyboard-media-menu branch June 27, 2022 16:15
@wilsonge wilsonge added this to the Joomla! 4.2.0 milestone Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility NPM Resource Changed This Pull Request can't be tested by Patchtester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants